From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: sched-ext@lists.linux.dev, void@manifault.com, arighi@nvidia.com,
changwoo@igalia.com, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH 0/2] tools/sched_ext: Sync configuration with upstream
Date: Mon, 16 Feb 2026 20:57:26 -1000 [thread overview]
Message-ID: <cc32f7a7dafb33666dec252ea0116887@kernel.org> (raw)
In-Reply-To: <20260216110014.771335-1-yphbchou0911@gmail.com>
Hello,
AI-assisted review follows. Please verify the points.
- Patch 1 doesn't apply. The pre-image includes CONFIG_PAHOLE_HAS_SPLIT_BTF
which has already been removed. Please rebase.
- Patch 2 has duplicate entries. CONFIG_BPF, CONFIG_BPF_SYSCALL,
CONFIG_BPF_JIT appear in both the mandatory section and the bpftrace
section.
- Patch 2 includes a number of options that are not user-selectable - they are
auto-selected by arch or other dependencies and have no effect in .config
fragments: CONFIG_HAVE_EBPF_JIT, CONFIG_HAVE_DYNAMIC_FTRACE,
CONFIG_HAVE_KPROBES, CONFIG_ARCH_SUPPORTS_UPROBES, CONFIG_PREEMPT_COUNT,
CONFIG_PREEMPTION, CONFIG_PREEMPT_RCU. These should be dropped.
- "more bpftrace to make that work" is a bit too casual as a comment. Please
clean it up.
Thanks.
--
tejun
prev parent reply other threads:[~2026-02-17 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 11:00 [PATCH 0/2] tools/sched_ext: Sync configuration with upstream Cheng-Yang Chou
2026-02-16 11:00 ` [PATCH 1/2] tools/sched_ext: Sync README.md Kconfig with upstream scx Cheng-Yang Chou
2026-02-16 11:00 ` [PATCH 2/2] tools/sched_ext: Add Kconfig to sync with upstream Cheng-Yang Chou
2026-02-17 6:57 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc32f7a7dafb33666dec252ea0116887@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox