[PATCH sched_ext/for-7.1] selftests/sched_ext: Improve runner error reporting for invalid arguments

[PATCH sched_ext/for-7.1] selftests/sched_ext: Improve runner error reporting for invalid arguments

[Cheng-Yang Chou]

Report an error for 'sudo ./runner foo' (positional arg instead of -t)
and for 'sudo ./runner -t foo' when the filter matches no tests.

Previously both cases produced no error output.

Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 tools/testing/selftests/sched_ext/runner.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tools/testing/selftests/sched_ext/runner.c b/tools/testing/selftests/sched_ext/runner.c
index d84f71eee049..e5640841cbfd 100644
--- a/tools/testing/selftests/sched_ext/runner.c
+++ b/tools/testing/selftests/sched_ext/runner.c
@@ -164,6 +164,12 @@ int main(int argc, char **argv)
 		}
 	}
 
+	if (optind < argc) {
+		fprintf(stderr, "Unexpected argument '%s'. Use -t to filter tests.\n",
+			argv[optind]);
+		return 1;
+	}
+
 	for (i = 0; i < __scx_num_tests; i++) {
 		enum scx_test_status status;
 		struct scx_test *test = &__scx_tests[i];
@@ -207,6 +213,15 @@ int main(int argc, char **argv)
 			break;
 		}
 	}
+
+	if (filter && testnum == 0 && !exit_req) {
+		fprintf(stderr, "No tests matched filter '%s'\n", filter);
+		fprintf(stderr, "Available tests (use -l to list):\n");
+		for (i = 0; i < __scx_num_tests; i++)
+			fprintf(stderr, "  %s\n", __scx_tests[i].name);
+		return 1;
+	}
+
 	printf("\n\n=============================\n\n");
 	printf("RESULTS:\n\n");
 	printf("PASSED:  %u\n", passed);
-- 
2.48.1

Re: [PATCH sched_ext/for-7.1] selftests/sched_ext: Improve runner error reporting for invalid arguments

[Tejun Heo]

Hello,

On Wed, Apr  8, 2026 at 01:49:02AM +0800, Cheng-Yang Chou wrote:
> +	if (filter && testnum == 0 && !exit_req) {

testnum is also bumped by the print_skipped path, so with
`-s -t nomatch` this check never fires.

Thanks.

--
tejun

[PATCH v2 sched_ext/for-7.1] selftests/sched_ext: Improve runner error reporting for invalid arguments

[Cheng-Yang Chou]

Report an error for './runner foo' (positional arg instead of -t) and
for './runner -t foo' when the filter matches no tests. Previously both
cases produced no error output.

Pre-scan the test list before the main loop so the error is reported
immediately, avoiding spurious SKIP output from '-s' when no tests
match.

Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
v2: Pre-scan before the main loop instead of checking testnum after,
    as testnum is also bumped by the print_skipped path. (Tejun Heo)

 tools/testing/selftests/sched_ext/runner.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tools/testing/selftests/sched_ext/runner.c b/tools/testing/selftests/sched_ext/runner.c
index d84f71eee049..c264807caa91 100644
--- a/tools/testing/selftests/sched_ext/runner.c
+++ b/tools/testing/selftests/sched_ext/runner.c
@@ -164,6 +164,26 @@ int main(int argc, char **argv)
 		}
 	}
 
+	if (optind < argc) {
+		fprintf(stderr, "Unexpected argument '%s'. Use -t to filter tests.\n",
+			argv[optind]);
+		return 1;
+	}
+
+	if (filter) {
+		for (i = 0; i < __scx_num_tests; i++) {
+			if (!should_skip_test(&__scx_tests[i], filter))
+				break;
+		}
+		if (i == __scx_num_tests) {
+			fprintf(stderr, "No tests matched filter '%s'\n", filter);
+			fprintf(stderr, "Available tests (use -l to list):\n");
+			for (i = 0; i < __scx_num_tests; i++)
+				fprintf(stderr, "  %s\n", __scx_tests[i].name);
+			return 1;
+		}
+	}
+
 	for (i = 0; i < __scx_num_tests; i++) {
 		enum scx_test_status status;
 		struct scx_test *test = &__scx_tests[i];
-- 
2.48.1

Re: [PATCH v2 sched_ext/for-7.1] selftests/sched_ext: Improve runner error reporting for invalid arguments

[Tejun Heo]

Hello,

On Wed, Apr 08, 2026 at 07:57:15AM +0800, Cheng-Yang Chou wrote:
> Report an error for './runner foo' (positional arg instead of -t) and
> for './runner -t foo' when the filter matches no tests. Previously both
> cases produced no error output.

Applied to sched_ext/for-7.1.

Thanks.

--
tejun