From: sashiko-bot@kernel.org
To: "Jonathan Bastari Thamrin" <thamrinjonathan@gmail.com>
Cc: sched-ext@lists.linux.dev
Subject: Re: [PATCH sched_ext for-7.4-fixes v2] selftests/sched_ext: Fix flaky rt_stall measurement
Date: Sun, 15 Nov 2026 15:19:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-215619@kernel.org> (raw)
In-Reply-To: <20261115-scx-rt-stall-v2-1-926678b214c6@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/sched_ext: leak of BPF skeleton in setup() on affinity
error
--
commit 24932bf17cf4d833030f3c4b3de4fdbf28e3d142
Author: Jonathan Bastari Thamrin <thamrinjonathan@gmail.com>
selftests/sched_ext: Fix flaky rt_stall measurement
This commit fixes flaky runtime measurements in the rt_stall selftest by
measuring per-task CPU clock deltas around the sleep window and pinning the
parent process off the test CPU.
Link: https://github.com/kernel-patches/vmtest/issues/458
> diff --git a/tools/testing/selftests/sched_ext/rt_stall.c b/tools/testing/selftests/sched_ext/rt_stall.c
> index a1552b38a6e8c..c5027fd6b6820 100644
> --- a/tools/testing/selftests/sched_ext/rt_stall.c
> +++ b/tools/testing/selftests/sched_ext/rt_stall.c
[ ... ]
> @@ -132,6 +149,9 @@ static enum scx_test_status setup(void **ctx)
>
> *ctx = skel;
>
> + err = pin_parent_off_core();
> + SCX_FAIL_IF(err == -1, "Failed to pin parent CPU");
> +
> return SCX_TEST_PASS;
> }
[Severity: Low]
Does this leak skel if pin_parent_off_core() fails? run_test() returns
immediately when test->setup() does not return SCX_TEST_PASS without
calling test->cleanup(), leaving the opened and loaded BPF skeleton
undestroyed across subsequent tests in the runner process.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-scx-rt-stall-v2-1-926678b214c6@gmail.com?part=1
next prev parent reply other threads:[~2026-11-15 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 15:11 [PATCH sched_ext for-7.4-fixes v2] selftests/sched_ext: Fix flaky rt_stall measurement Jonathan Bastari Thamrin via B4 Relay
2026-11-15 15:19 ` sashiko-bot [this message]
2026-11-15 15:48 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215619@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sched-ext@lists.linux.dev \
--cc=thamrinjonathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox