Sched_ext development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jonathan Bastari Thamrin" <thamrinjonathan@gmail.com>
Cc: sched-ext@lists.linux.dev
Subject: Re: [PATCH sched_ext for-7.4-fixes v3] selftests/sched_ext: Reduce rt_stall measurement noise
Date: Sun, 15 Nov 2026 18:17:12 +0000	[thread overview]
Message-ID: <sashiko-outbox-215705@kernel.org> (raw)
In-Reply-To: <20261116-scx-rt-stall-v3-1-8dd2d150c4aa@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/sched_ext: BPF skeleton leak on error return in
  setup()
--

commit 460edb58a551fd13069d6da200d43512c93cb197
Author: Jonathan Bastari Thamrin <thamrinjonathan@gmail.com>

selftests/sched_ext: Reduce rt_stall measurement noise

This commit reduces runtime measurement noise in the rt_stall selftest by
measuring task CPU time deltas across the sleep window with
clock_getcpuclockid() and pinning the parent process off CORE_ID.

Link: https://github.com/kernel-patches/vmtest/issues/458

> diff --git a/tools/testing/selftests/sched_ext/rt_stall.c b/tools/testing/selftests/sched_ext/rt_stall.c
> index a1552b38a6e8c..7be801b1fa2bd 100644
> --- a/tools/testing/selftests/sched_ext/rt_stall.c
> +++ b/tools/testing/selftests/sched_ext/rt_stall.c

[ ... ]

> @@ -132,6 +149,9 @@ static enum scx_test_status setup(void **ctx)
>  
>  	*ctx = skel;
>  
> +	err = pin_parent_off_core();
> +	SCX_FAIL_IF(err == -1, "Failed to pin parent CPU");

[Severity: Low]
Does this leak skel if pin_parent_off_core() fails?

setup() has already opened and loaded skel via rt_stall__open() and
rt_stall__load() (which also leaks skel on load failure).  When
test->setup() does not return SCX_TEST_PASS, run_test() in runner.c
returns immediately without calling test->cleanup(), leaving skel and its
BPF program and map file descriptors open for the rest of the multi-test
runner process.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-scx-rt-stall-v3-1-8dd2d150c4aa@gmail.com?part=1

  reply	other threads:[~2026-11-15 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 18:10 [PATCH sched_ext for-7.4-fixes v3] selftests/sched_ext: Reduce rt_stall measurement noise Jonathan Bastari Thamrin via B4 Relay
2026-11-15 18:17 ` sashiko-bot [this message]
2026-11-15 20:33 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215705@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sched-ext@lists.linux.dev \
    --cc=thamrinjonathan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox