From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0695C433EF for ; Fri, 18 Feb 2022 00:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbiBRA0Y (ORCPT ); Thu, 17 Feb 2022 19:26:24 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:56114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbiBRA0X (ORCPT ); Thu, 17 Feb 2022 19:26:23 -0500 Received: from smtp.sws.net.au (smtp.sws.net.au [144.76.241.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 816F5B64 for ; Thu, 17 Feb 2022 16:26:04 -0800 (PST) Received: from xev.coker.com.au (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id 9EA3C10F00; Fri, 18 Feb 2022 11:26:00 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1645143961; bh=2pmmVLaa60Vj+clZ1aIoEnVFOEa9rNPjfM9sQGI1Jb4=; l=2741; h=From:To:Reply-To:Cc:Subject:Date:In-Reply-To:References:From; b=beR69SoEa75Eyq+MsMtfGtQDbBs5I4g+BUI+M+bLB7KADlt09VhQY1Im3qaeGvylA KjI82uYm+SVxGpoG0fzkZEnnM5HOanIDZBCdEepI0gKAKqlN8UouOXtR7wBMolbjpt 27W0rXYmE0xniGjMlNwctDsamEklelFVCoxbz57w= Received: by xev.coker.com.au (Postfix, from userid 1001) id D919D1735D12; Fri, 18 Feb 2022 11:25:55 +1100 (AEDT) From: Russell Coker To: Chris PeBenito Reply-To: russell@coker.com.au Cc: selinux-refpolicy@vger.kernel.org Subject: Re: [PATCH] rasdaemon (replacement for mcelog) Date: Fri, 18 Feb 2022 11:25:55 +1100 Message-ID: <18698496.iPHH8zDuP6@xev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On Saturday, 13 March 2021 02:03:48 AEDT Chris PeBenito wrote: > On 3/8/21 3:59 AM, Dominick Grift wrote: > > Dominick Grift writes: > >> Russell Coker writes: > >>> This is policy for rasdaemon, the new replacement for mcelog. The > >>> /dev/mcelog device is now an obsolete kernel feature that can be enabled > >>> for backward compatibility and rasdaeon with tracefs is the new way. > >>> > >>> I've tested this and it seems to work OK, but all my servers are working > >>> well so I haven't been able to test the case of actually detecting an > >>> error. It would be good if someone with a known damaged server could > >>> give > >>> it a go. > >>> > >>> I think this is ready for merging. > >>> > >>> Signed-off-by: Russell Coker > > [...] > > >>> +++ refpolicy-2.20210203/policy/modules/services/rasdaemon.te > >>> @@ -0,0 +1,49 @@ > >>> +policy_module(rasdaemon, 1.0.0) > >>> + > >>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability) > >>> logging +# tool. It currently records memory errors, using the EDAC > >>> tracing events. +# EDAC are drivers in the Linux kernel that handle > >>> detection of ECC errors +# from memory controllers for most chipsets on > >>> x86 and ARM architectures. +# > >>> +# https://git.infradead.org/users/mchehab/rasdaemon.git > >> > >> Please use the for description. We have an api > >> browser (make doc) and the description should end up there as well. > >> > >> Reliability, Availability and Serviceability (RAS) logging > >> tool. > >> > >> I would omit the url because those are often subject to change anyway. > > I agree if we have this amount of description it should go in the XML, but > the module level actually has a tag that goes after . I > like Dominick's summary, but the Russel's comment can go in the module > . > > The URL can remain. Yes, it can change, but at least there are some > breadcrumbs if this program becomes obsolete or unmaintained. So you mean having the following in rasdaemon.if ? ## RAS (Reliability, Availability and Serviceability) logging tool ## ## ## rasdaemon is a RAS (Reliability, Availability and Serviceability) logging ## tool. It currently records memory errors, using the EDAC tracing events. ## EDAC are drivers in the Linux kernel that handle detection of ECC errors ## from memory controllers for most chipsets on x86 and ARM architectures. ## ## https://git.infradead.org/users/mchehab/rasdaemon.git ## -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/