From: James Carter <jwcart2@gmail.com>
To: selinux@vger.kernel.org
Cc: James Carter <jwcart2@gmail.com>
Subject: [PATCH] libselinux: Do not inline compile_regex()
Date: Wed, 11 Jun 2025 14:28:46 -0400 [thread overview]
Message-ID: <20250611182846.236298-1-jwcart2@gmail.com> (raw)
Since commit bdcbbf89b9548afd452449835e58e84105a71a9a (libselinux:
limit fcontext regex path length), an error would be given if
libselinux was compiled directly. (Though, building the whole SELinux
userspace still worked.) This is because the flag "-Winline" is used
when building libselinux directly, but not when building the whole
userspace.
Remove "inline" from the function compile_regex() in label_file.h
to allow libselinux to be built directly.
There are four functions defined in label_file.h that are not inlined:
regex_has_meta_chars(), regex_simplify(), compile_regex(), and
insert_spec(). The first three functions are called by insert_spec()
which is called by the inlined function process_line(). This last
function is called by utils/sefcontext_compile.c which prevents
relocating the non-inlined functions to label_file.c.
Signed-off-by: James Carter <jwcart2@gmail.com>
---
libselinux/src/label_file.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libselinux/src/label_file.h b/libselinux/src/label_file.h
index d1a0713a..8fcf74e3 100644
--- a/libselinux/src/label_file.h
+++ b/libselinux/src/label_file.h
@@ -390,7 +390,7 @@ static inline void sort_specs(struct saved_data *data)
sort_spec_node(data->root, NULL);
}
-static inline int compile_regex(struct regex_spec *spec, char *errbuf, size_t errbuf_size)
+static int compile_regex(struct regex_spec *spec, char *errbuf, size_t errbuf_size)
{
const char *reg_buf;
char *anchored_regex, *cp;
--
2.49.0
next reply other threads:[~2025-06-11 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 18:28 James Carter [this message]
2025-06-11 18:31 ` [PATCH] libselinux: Do not inline compile_regex() Stephen Smalley
2025-06-11 19:10 ` Petr Lautrbach
2025-06-11 19:13 ` Stephen Smalley
2025-06-11 19:17 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611182846.236298-1-jwcart2@gmail.com \
--to=jwcart2@gmail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).