From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: selinux@vger.kernel.org
Cc: paul@paul-moore.com, omosnace@redhat.com,
Stephen Smalley <stephen.smalley.work@gmail.com>
Subject: [PATCH] tests/mac_admin: skip another test on nfs
Date: Wed, 18 Jun 2025 12:29:43 -0400 [thread overview]
Message-ID: <20250618162942.124309-2-stephen.smalley.work@gmail.com> (raw)
Skip another test of undefined label handling that is not guaranteed to
work over labeled NFS and breaks if SELinux namespaces are enabled due
to the global SID table correctly preserving the undefined context value,
producing an error within NFSv4 for which no error handling path exists.
Possibly consider disabling this entire set of tests.
Signed-off-by: Stephen Smalley <stephen.smalley.work@gmail.com>
---
tests/mac_admin/test | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/mac_admin/test b/tests/mac_admin/test
index c28a7bc..8ecb48b 100755
--- a/tests/mac_admin/test
+++ b/tests/mac_admin/test
@@ -11,7 +11,7 @@ BEGIN {
plan tests => 8;
}
else {
- plan tests => 7;
+ plan tests => 6;
}
}
@@ -49,12 +49,13 @@ if ( $isnfs ne "nfs" ) {
`runcon -t test_mac_admin_t -- secon -t -f $basedir/test_dir 2>&1`;
chomp($result);
ok( $result, "UNDEFINED" );
-}
-# Verify that test_no_mac_admin_t sees the unlabeled context.
-$result = `runcon -t test_no_mac_admin_t -- secon -t -f $basedir/test_dir 2>&1`;
-chomp($result);
-ok( $result, "unlabeled_t" );
+ # Verify that test_no_mac_admin_t sees the unlabeled context.
+ $result =
+ `runcon -t test_no_mac_admin_t -- secon -t -f $basedir/test_dir 2>&1`;
+ chomp($result);
+ ok( $result, "unlabeled_t" );
+}
# Delete the test directory
system("rm -rf $basedir/test_dir");
--
2.49.0
next reply other threads:[~2025-06-18 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 16:29 Stephen Smalley [this message]
2025-06-23 13:37 ` [PATCH] tests/mac_admin: skip another test on nfs Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618162942.124309-2-stephen.smalley.work@gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).