[PATCH] build: Make sure SHLIBDIR respects PREFIX

[PATCH] build: Make sure SHLIBDIR respects PREFIX

[Rahul Sandhu]

Not respecting PREFIX can pollute the environment in various build
configurations. LIBDIR already respects it, so we may as well make
SHLIBDIR respect PREFIX too. Fixes #494 on Github[1].

[1] https://github.com/SELinuxProject/selinux/issues/494

Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>
---
 libselinux/src/Makefile | 2 +-
 libsepol/src/Makefile   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
index 261c22d4..c855e759 100644
--- a/libselinux/src/Makefile
+++ b/libselinux/src/Makefile
@@ -10,7 +10,7 @@ PKG_CONFIG ?= pkg-config
 # Installation directories.
 PREFIX ?= /usr
 LIBDIR ?= $(PREFIX)/lib
-SHLIBDIR ?= /lib
+SHLIBDIR ?= $(PREFIX)/lib
 INCLUDEDIR ?= $(PREFIX)/include
 PYINC ?= $(shell $(PKG_CONFIG) --cflags $(PYPREFIX))
 PYLIBS ?= $(shell $(PKG_CONFIG) --libs $(PYPREFIX))
diff --git a/libsepol/src/Makefile b/libsepol/src/Makefile
index a1aed072..f8574d70 100644
--- a/libsepol/src/Makefile
+++ b/libsepol/src/Makefile
@@ -2,7 +2,7 @@
 PREFIX ?= /usr
 INCLUDEDIR ?= $(PREFIX)/include
 LIBDIR ?= $(PREFIX)/lib
-SHLIBDIR ?= /lib
+SHLIBDIR ?= $(PREFIX)/lib
 RANLIB ?= ranlib
 CILDIR ?= ../cil
 
-- 
2.50.1

Re: [PATCH] build: Make sure SHLIBDIR respects PREFIX

[Stephen Smalley]

On Thu, Sep 25, 2025 at 1:27 PM Rahul Sandhu <nvraxn@gmail.com> wrote:
>
> Not respecting PREFIX can pollute the environment in various build
> configurations. LIBDIR already respects it, so we may as well make
> SHLIBDIR respect PREFIX too. Fixes #494 on Github[1].
>
> [1] https://github.com/SELinuxProject/selinux/issues/494

If you don't have usrmerge, this can produce the wrong result by
default, i.e. installing shared libraries to /usr/lib instead of /lib.

>
> Signed-off-by: Rahul Sandhu <nvraxn@gmail.com>
> ---
>  libselinux/src/Makefile | 2 +-
>  libsepol/src/Makefile   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> index 261c22d4..c855e759 100644
> --- a/libselinux/src/Makefile
> +++ b/libselinux/src/Makefile
> @@ -10,7 +10,7 @@ PKG_CONFIG ?= pkg-config
>  # Installation directories.
>  PREFIX ?= /usr
>  LIBDIR ?= $(PREFIX)/lib
> -SHLIBDIR ?= /lib
> +SHLIBDIR ?= $(PREFIX)/lib
>  INCLUDEDIR ?= $(PREFIX)/include
>  PYINC ?= $(shell $(PKG_CONFIG) --cflags $(PYPREFIX))
>  PYLIBS ?= $(shell $(PKG_CONFIG) --libs $(PYPREFIX))
> diff --git a/libsepol/src/Makefile b/libsepol/src/Makefile
> index a1aed072..f8574d70 100644
> --- a/libsepol/src/Makefile
> +++ b/libsepol/src/Makefile
> @@ -2,7 +2,7 @@
>  PREFIX ?= /usr
>  INCLUDEDIR ?= $(PREFIX)/include
>  LIBDIR ?= $(PREFIX)/lib
> -SHLIBDIR ?= /lib
> +SHLIBDIR ?= $(PREFIX)/lib
>  RANLIB ?= ranlib
>  CILDIR ?= ../cil
>
> --
> 2.50.1
>
>