SELinux Security Module development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH v2 3/3] selinux: validate permissive and neveraudit map types at load
Date: Mon, 28 Sep 2026 17:07:21 +0000	[thread overview]
Message-ID: <20260928170722.1D79A1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260928165253.2388012-2-cgoettsche@seltendoof.de>

> From: Christian Göttsche <cgzones@googlemail.com>
> 
> The permissive and neveraudit maps are read as ebitmaps and indexed by
> type value, but their set bits are never checked. A bit that is not a
> defined, non-attribute type is silently accepted. Validate every set bit
> of both maps in policydb_index() with policydb_simpletype_isvalid().
> 
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928165253.2388012-3-cgoettsche@seltendoof.de?part=3


  reply	other threads:[~2026-09-28 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 16:52 [PATCH v2 2/3] selinux: validate user MLS range and default level at load Christian Göttsche
2026-09-28 16:52 ` [PATCH v2 3/3] selinux: validate permissive and neveraudit map types " Christian Göttsche
2026-09-28 17:07   ` sashiko-bot [this message]
2026-09-29 13:11   ` Stephen Smalley
2026-09-30 20:59   ` Paul Moore
2026-09-28 16:52 ` [PATCH v2 1/3] selinux: bounds-check role and user membership bitmaps " Christian Göttsche
2026-09-28 17:03   ` sashiko-bot
2026-09-28 17:49   ` Stephen Smalley
2026-09-28 17:54     ` Stephen Smalley
2026-09-28 18:20       ` Stephen Smalley
2026-09-30 20:59   ` Paul Moore
2026-09-28 17:01 ` [PATCH v2 2/3] selinux: validate user MLS range and default level " sashiko-bot
2026-09-28 19:48 ` [RFC PATCH 15/32] selinux: make mls_level_isvalid() static Stephen Smalley
2026-09-29 13:11 ` [PATCH v2 2/3] selinux: validate user MLS range and default level at load Stephen Smalley
2026-09-30 20:59 ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928170722.1D79A1F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox