[PATCH v2] policycoreutils: make `-laudit -lbz2` conditional

[PATCH v2] policycoreutils: make `-laudit -lbz2` conditional

[Petr Lautrbach]

Commit da6cd3d8d7600 ("Support static-only builds") introduced possibility
to build static-only toolchain. For static builds of `semodule` and
`setsebool` seems to be necessary to use `-laudit -lbz2`. As an side
effect, when policycoreutils is built without other components, the
buildroot requires libaudit.so and libbz2.so to be available. For shared
builds this is not necessary and had not been required before.

Signed-off-by: Petr Lautrbach <lautrbach@redhat.com>
---

v2: fixed indentation, I was inspired by the wrong file :/

 policycoreutils/semodule/Makefile  | 2 ++
 policycoreutils/setsebool/Makefile | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/policycoreutils/semodule/Makefile b/policycoreutils/semodule/Makefile
index 7c45831fcd4e..52a68dfcac10 100644
--- a/policycoreutils/semodule/Makefile
+++ b/policycoreutils/semodule/Makefile
@@ -12,7 +12,9 @@ SEMODULE_OBJS = semodule.o
 
 all: semodule genhomedircon
 
+ifeq ($(DISABLE_SHARED),y)
 semodule: LDLIBS += -laudit -lbz2
+endif
 semodule: $(SEMODULE_OBJS)
 
 genhomedircon:
diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
index 1d5148469f01..f68440f90df7 100644
--- a/policycoreutils/setsebool/Makefile
+++ b/policycoreutils/setsebool/Makefile
@@ -15,7 +15,9 @@ BASHCOMPLETIONS=setsebool-bash-completion.sh
 
 all: setsebool
 
+ifeq ($(DISABLE_SHARED),y)
 setsebool: LDLIBS += -laudit -lbz2
+endif
 setsebool: $(SETSEBOOL_OBJS)
 
 install: all
-- 
2.49.0

Re: [PATCH v2] policycoreutils: make `-laudit -lbz2` conditional

[James Carter]

On Mon, Jun 23, 2025 at 2:07 PM Petr Lautrbach <lautrbach@redhat.com> wrote:
>
> Commit da6cd3d8d7600 ("Support static-only builds") introduced possibility
> to build static-only toolchain. For static builds of `semodule` and
> `setsebool` seems to be necessary to use `-laudit -lbz2`. As an side
> effect, when policycoreutils is built without other components, the
> buildroot requires libaudit.so and libbz2.so to be available. For shared
> builds this is not necessary and had not been required before.
>
> Signed-off-by: Petr Lautrbach <lautrbach@redhat.com>

Acked-by: James Carter <jwcart2@gmail.com>

> ---
>
> v2: fixed indentation, I was inspired by the wrong file :/
>
>  policycoreutils/semodule/Makefile  | 2 ++
>  policycoreutils/setsebool/Makefile | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/policycoreutils/semodule/Makefile b/policycoreutils/semodule/Makefile
> index 7c45831fcd4e..52a68dfcac10 100644
> --- a/policycoreutils/semodule/Makefile
> +++ b/policycoreutils/semodule/Makefile
> @@ -12,7 +12,9 @@ SEMODULE_OBJS = semodule.o
>
>  all: semodule genhomedircon
>
> +ifeq ($(DISABLE_SHARED),y)
>  semodule: LDLIBS += -laudit -lbz2
> +endif
>  semodule: $(SEMODULE_OBJS)
>
>  genhomedircon:
> diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
> index 1d5148469f01..f68440f90df7 100644
> --- a/policycoreutils/setsebool/Makefile
> +++ b/policycoreutils/setsebool/Makefile
> @@ -15,7 +15,9 @@ BASHCOMPLETIONS=setsebool-bash-completion.sh
>
>  all: setsebool
>
> +ifeq ($(DISABLE_SHARED),y)
>  setsebool: LDLIBS += -laudit -lbz2
> +endif
>  setsebool: $(SETSEBOOL_OBJS)
>
>  install: all
> --
> 2.49.0
>
>

Re: [PATCH v2] policycoreutils: make `-laudit -lbz2` conditional

[James Carter]

On Mon, Jun 23, 2025 at 2:08 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Mon, Jun 23, 2025 at 2:07 PM Petr Lautrbach <lautrbach@redhat.com> wrote:
> >
> > Commit da6cd3d8d7600 ("Support static-only builds") introduced possibility
> > to build static-only toolchain. For static builds of `semodule` and
> > `setsebool` seems to be necessary to use `-laudit -lbz2`. As an side
> > effect, when policycoreutils is built without other components, the
> > buildroot requires libaudit.so and libbz2.so to be available. For shared
> > builds this is not necessary and had not been required before.
> >
> > Signed-off-by: Petr Lautrbach <lautrbach@redhat.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
>

I think this has been superseded by Alyssa's and my patches.
Correct?
Jim

> > ---
> >
> > v2: fixed indentation, I was inspired by the wrong file :/
> >
> >  policycoreutils/semodule/Makefile  | 2 ++
> >  policycoreutils/setsebool/Makefile | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/policycoreutils/semodule/Makefile b/policycoreutils/semodule/Makefile
> > index 7c45831fcd4e..52a68dfcac10 100644
> > --- a/policycoreutils/semodule/Makefile
> > +++ b/policycoreutils/semodule/Makefile
> > @@ -12,7 +12,9 @@ SEMODULE_OBJS = semodule.o
> >
> >  all: semodule genhomedircon
> >
> > +ifeq ($(DISABLE_SHARED),y)
> >  semodule: LDLIBS += -laudit -lbz2
> > +endif
> >  semodule: $(SEMODULE_OBJS)
> >
> >  genhomedircon:
> > diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
> > index 1d5148469f01..f68440f90df7 100644
> > --- a/policycoreutils/setsebool/Makefile
> > +++ b/policycoreutils/setsebool/Makefile
> > @@ -15,7 +15,9 @@ BASHCOMPLETIONS=setsebool-bash-completion.sh
> >
> >  all: setsebool
> >
> > +ifeq ($(DISABLE_SHARED),y)
> >  setsebool: LDLIBS += -laudit -lbz2
> > +endif
> >  setsebool: $(SETSEBOOL_OBJS)
> >
> >  install: all
> > --
> > 2.49.0
> >
> >

Re: [PATCH v2] policycoreutils: make `-laudit -lbz2` conditional

[Petr Lautrbach]

James Carter <jwcart2@gmail.com> writes:

> On Mon, Jun 23, 2025 at 2:08 PM James Carter <jwcart2@gmail.com> wrote:
>>
>> On Mon, Jun 23, 2025 at 2:07 PM Petr Lautrbach <lautrbach@redhat.com> wrote:
>> >
>> > Commit da6cd3d8d7600 ("Support static-only builds") introduced possibility
>> > to build static-only toolchain. For static builds of `semodule` and
>> > `setsebool` seems to be necessary to use `-laudit -lbz2`. As an side
>> > effect, when policycoreutils is built without other components, the
>> > buildroot requires libaudit.so and libbz2.so to be available. For shared
>> > builds this is not necessary and had not been required before.
>> >
>> > Signed-off-by: Petr Lautrbach <lautrbach@redhat.com>
>>
>> Acked-by: James Carter <jwcart2@gmail.com>
>>
>
> I think this has been superseded by Alyssa's and my patches.
> Correct?
> Jim

Correct.

I'm able to build policycoreutils with Alyssa's and my patches and
without this patch.

Thanks!.

>
>> > ---
>> >
>> > v2: fixed indentation, I was inspired by the wrong file :/
>> >
>> >  policycoreutils/semodule/Makefile  | 2 ++
>> >  policycoreutils/setsebool/Makefile | 2 ++
>> >  2 files changed, 4 insertions(+)
>> >
>> > diff --git a/policycoreutils/semodule/Makefile b/policycoreutils/semodule/Makefile
>> > index 7c45831fcd4e..52a68dfcac10 100644
>> > --- a/policycoreutils/semodule/Makefile
>> > +++ b/policycoreutils/semodule/Makefile
>> > @@ -12,7 +12,9 @@ SEMODULE_OBJS = semodule.o
>> >
>> >  all: semodule genhomedircon
>> >
>> > +ifeq ($(DISABLE_SHARED),y)
>> >  semodule: LDLIBS += -laudit -lbz2
>> > +endif
>> >  semodule: $(SEMODULE_OBJS)
>> >
>> >  genhomedircon:
>> > diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
>> > index 1d5148469f01..f68440f90df7 100644
>> > --- a/policycoreutils/setsebool/Makefile
>> > +++ b/policycoreutils/setsebool/Makefile
>> > @@ -15,7 +15,9 @@ BASHCOMPLETIONS=setsebool-bash-completion.sh
>> >
>> >  all: setsebool
>> >
>> > +ifeq ($(DISABLE_SHARED),y)
>> >  setsebool: LDLIBS += -laudit -lbz2
>> > +endif
>> >  setsebool: $(SETSEBOOL_OBJS)
>> >
>> >  install: all
>> > --
>> > 2.49.0
>> >
>> >