SELinux Security Module development
 help / color / mirror / Atom feed
From: Petr Lautrbach <plautrba@redhat.com>
To: SElinux list <selinux@vger.kernel.org>
Cc: Nicolas Iooss <nicolas.iooss@m4x.org>, bauen1 <j2468h@googlemail.com>
Subject: Re: [PATCH v3] policycoreutils: sestatus belongs to bin not sbin
Date: Wed, 24 Feb 2021 11:57:44 +0100	[thread overview]
Message-ID: <87a6rt3f87.fsf@redhat.com> (raw)
In-Reply-To: <CAJfZ7=kC2LWD7CFPebVmcVSRC7sijROxp9R4UWdyg2xfBH1e2A@mail.gmail.com>

Nicolas Iooss <nicolas.iooss@m4x.org> writes:

> On Sun, Feb 21, 2021 at 5:04 PM bauen1 <j2468h@googlemail.com> wrote:
>>
>> It is quite useful even to non-privileged users and doesn't require any
>> privileges to work, except for maybe -v.
>>
>> Some tools hard code the old path, so a compatibility symlink is also
>> created.
>>
>> Signed-off-by: Jonathan Hettwer <j2468h@gmail.com>
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>

Merged, thanks!

> Thanks!
> Nicolas
>
>> ---
>>  policycoreutils/sestatus/Makefile | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/policycoreutils/sestatus/Makefile b/policycoreutils/sestatus/Makefile
>> index 8c4f45f8..3dbb792b 100644
>> --- a/policycoreutils/sestatus/Makefile
>> +++ b/policycoreutils/sestatus/Makefile
>> @@ -1,6 +1,7 @@
>>  # Installation directories.
>>  LINGUAS ?= ru
>>  PREFIX ?= /usr
>> +BINDIR ?= $(PREFIX)/bin
>>  SBINDIR ?= $(PREFIX)/sbin
>>  MANDIR = $(PREFIX)/share/man
>>  ETCDIR ?= /etc
>> @@ -16,8 +17,13 @@ sestatus: sestatus.o
>>  install: all
>>         [ -d $(DESTDIR)$(MANDIR)/man8 ] || mkdir -p $(DESTDIR)$(MANDIR)/man8
>>         [ -d $(DESTDIR)$(MANDIR)/man5 ] || mkdir -p $(DESTDIR)$(MANDIR)/man5
>> +       -mkdir -p $(DESTDIR)$(BINDIR)
>>         -mkdir -p $(DESTDIR)$(SBINDIR)
>> -       install -m 755 sestatus $(DESTDIR)$(SBINDIR)
>> +       # Some tools hard code /usr/sbin/sestatus ; add a compatibility symlink
>> +       # install will overwrite a symlink, so create the symlink before calling
>> +       # install to allow distributions with BINDIR == SBINDIR
>> +       ln -sf --relative $(DESTDIR)$(BINDIR)/sestatus $(DESTDIR)$(SBINDIR)
>> +       install -m 755 sestatus $(DESTDIR)$(BINDIR)
>>         install -m 644 sestatus.8 $(DESTDIR)$(MANDIR)/man8
>>         install -m 644 sestatus.conf.5 $(DESTDIR)$(MANDIR)/man5
>>         for lang in $(LINGUAS) ; do \
>> --
>> 2.30.1
>>


      reply	other threads:[~2021-02-24 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 16:04 [PATCH v3] policycoreutils: sestatus belongs to bin not sbin bauen1
2021-02-21 19:02 ` Nicolas Iooss
2021-02-24 10:57   ` Petr Lautrbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6rt3f87.fsf@redhat.com \
    --to=plautrba@redhat.com \
    --cc=j2468h@googlemail.com \
    --cc=nicolas.iooss@m4x.org \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox