selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Lautrbach <plautrba@redhat.com>
To: selinux@vger.kernel.org
Cc: kdudka@redhat.com
Subject: review needed - coreutils ported to a newer version of libselinux
Date: Mon, 30 Nov 2020 11:39:14 +0100	[thread overview]
Message-ID: <87k0u3p1rh.fsf@redhat.com> (raw)


Hello,

a week ago I was asked to review coreutils changes which migrated
coreutils from matchpathcon() to selabel_lookup(), see bellow. Sadly I
wasn't able to do it yet so I would really appreciate if somebody can
help with this. I've CCed Kamil who should be answer coreutils related
questions.

Thanks!

quote:

Upstream has ported GNU coreutils to a newer version of libselinux.  Namely,
it uses selabel_lookup() instead of matchpathcon().  They are now asking for
a review by an SELinux expert from Red Hat:

    https://lists.gnu.org/archive/html/coreutils/2020-11/msg00049.html

Could you (or someone from your team) please review the following upstream
commits?

    https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.32-76-g3aaa42deaa
    https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.32-79-g7b341f084b
    https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.32-81-gd12f5da6d4

And there's another follow-up at
    https://lists.gnu.org/archive/html/coreutils/2020-11/msg00054.html



                 reply	other threads:[~2020-11-30 10:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0u3p1rh.fsf@redhat.com \
    --to=plautrba@redhat.com \
    --cc=kdudka@redhat.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).