From: Petr Lautrbach <plautrba@redhat.com>
To: "Christian Göttsche" <cgzones@googlemail.com>, selinux@vger.kernel.org
Subject: Re: [PATCH v2 2/6] libsepol/cil: drop unused function cil_tree_error
Date: Wed, 06 Apr 2022 16:33:23 +0200 [thread overview]
Message-ID: <87y20inux8.fsf@redhat.com> (raw)
In-Reply-To: <20220405133548.51598-2-cgzones@googlemail.com>
Christian Göttsche <cgzones@googlemail.com> writes:
> It seems to be unused since its initial addition in 76ba6eaa
> ("Squashed 'libsepol/cil/' changes from 08520e9..28ad56e").
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Already merged from
https://patchwork.kernel.org/project/selinux/patch/20220331144752.31495-2-cgzones@googlemail.com/
based on ack from https://lore.kernel.org/all/CAP+JOzRYFWE=sL05iWJJSYxr+0bAXKBe=d9Kim1h4=jAZ85xZQ@mail.gmail.com/
> ---
> libsepol/cil/src/cil_tree.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/libsepol/cil/src/cil_tree.c b/libsepol/cil/src/cil_tree.c
> index 525b60d4..6376c208 100644
> --- a/libsepol/cil/src/cil_tree.c
> +++ b/libsepol/cil/src/cil_tree.c
> @@ -41,15 +41,6 @@
> #include "cil_parser.h"
> #include "cil_strpool.h"
>
> -__attribute__((noreturn)) __attribute__((format (printf, 1, 2))) void cil_tree_error(const char* msg, ...)
> -{
> - va_list ap;
> - va_start(ap, msg);
> - cil_vlog(CIL_ERR, msg, ap);
> - va_end(ap);
> - exit(1);
> -}
> -
> struct cil_tree_node *cil_tree_get_next_path(struct cil_tree_node *node, char **info_kind, uint32_t *hll_line, char **path)
> {
> int rc;
> --
> 2.35.1
next prev parent reply other threads:[~2022-04-06 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 14:47 [RFC PATCH 1/4] libsepol/cil: declare file local functions static Christian Göttsche
2022-03-31 14:47 ` [RFC PATCH 2/4] libsepol/cil: drop unused function cil_tree_error Christian Göttsche
2022-04-01 20:51 ` James Carter
2022-03-31 14:47 ` [RFC PATCH 3/4] libsepol/cil: post process pirqcon rules Christian Göttsche
2022-04-01 20:51 ` James Carter
2022-03-31 14:47 ` [RFC PATCH 4/4] Enable missing prototypes Christian Göttsche
2022-04-01 20:58 ` James Carter
2022-04-01 20:50 ` [RFC PATCH 1/4] libsepol/cil: declare file local functions static James Carter
2022-04-05 13:35 ` [PATCH v2 1/6] " Christian Göttsche
2022-04-05 13:35 ` [PATCH v2 2/6] libsepol/cil: drop unused function cil_tree_error Christian Göttsche
2022-04-06 14:33 ` Petr Lautrbach [this message]
2022-04-05 13:35 ` [PATCH v2 3/6] libsepol/cil: post process pirqcon rules Christian Göttsche
2022-04-06 14:35 ` Petr Lautrbach
2022-04-05 13:35 ` [PATCH v2 4/6] libsepol/cil: comment out unused function __cil_verify_rule Christian Göttsche
2022-04-06 16:15 ` James Carter
2022-04-20 19:04 ` James Carter
2022-04-05 13:35 ` [PATCH v2 5/6] libsemanage: ignore missing prototypes in swig generated code Christian Göttsche
2022-04-05 13:35 ` [PATCH v2 6/6] Enable missing prototypes Christian Göttsche
2022-04-12 18:14 ` James Carter
2022-04-06 14:29 ` [PATCH v2 1/6] libsepol/cil: declare file local functions static Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y20inux8.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox