selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] GitHub Actions: upgrade to Python 3.9
@ 2020-12-06 22:56 Nicolas Iooss
  2020-12-06 22:56 ` [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix Nicolas Iooss
  2020-12-07 16:43 ` [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 William Roberts
  0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Iooss @ 2020-12-06 22:56 UTC (permalink / raw)
  To: selinux

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---
 .github/workflows/run_tests.yml | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
index 6f280de8ff4d..d889b5d55604 100644
--- a/.github/workflows/run_tests.yml
+++ b/.github/workflows/run_tests.yml
@@ -10,25 +10,26 @@ jobs:
       matrix:
         compiler: [gcc, clang]
         python-ruby-version:
-          - {python: 3.8, ruby: 2.7}
-          - {python: 3.8, ruby: 2.7, other: test-flags-override}
-          - {python: 3.8, ruby: 2.7, other: test-debug}
-          - {python: 3.8, ruby: 2.7, other: linker-bfd}
-          - {python: 3.8, ruby: 2.7, other: linker-gold}
+          - {python: 3.9, ruby: 2.7}
+          - {python: 3.9, ruby: 2.7, other: test-flags-override}
+          - {python: 3.9, ruby: 2.7, other: test-debug}
+          - {python: 3.9, ruby: 2.7, other: linker-bfd}
+          - {python: 3.9, ruby: 2.7, other: linker-gold}
           # Test several Python versions with the latest Ruby version
+          - {python: 3.8, ruby: 2.7}
           - {python: 3.7, ruby: 2.7}
           - {python: 3.6, ruby: 2.7}
           - {python: 3.5, ruby: 2.7}
           - {python: pypy3, ruby: 2.7}
           # Test several Ruby versions with the latest Python version
-          - {python: 3.8, ruby: 2.6}
-          - {python: 3.8, ruby: 2.5}
-          - {python: 3.8, ruby: 2.4}
+          - {python: 3.9, ruby: 2.6}
+          - {python: 3.9, ruby: 2.5}
+          - {python: 3.9, ruby: 2.4}
         exclude:
           - compiler: clang
-            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-bfd}
+            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
           - compiler: clang
-            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-gold}
+            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-gold}
 
     steps:
     - uses: actions/checkout@v2
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix
  2020-12-06 22:56 [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 Nicolas Iooss
@ 2020-12-06 22:56 ` Nicolas Iooss
  2020-12-07 16:42   ` William Roberts
  2020-12-07 16:43 ` [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 William Roberts
  1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Iooss @ 2020-12-06 22:56 UTC (permalink / raw)
  To: selinux

When migrating to Ubuntu 20.04, Ruby 2.4 is no longer available. As the
migration of "ubuntu-latest" to Ubuntu 20.04 is coming soon, according
to https://github.com/actions/virtual-environments/issues/1816, remove
it now.

Moreover the support of Ruby 2.4 ended a few months ago, so there is no
point at supporting bindings (and testing them) for this version:
https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---

I hit this on https://github.com/fishilico/selinux/runs/1507627386?check_suite_focus=true
and the fix is simple.
I would like to keep using ubuntu-latest image in order to benefit from
automatic "LTS upgrade" when they become available. I find it better
than having to update the Ubuntu version by hand (like was done for the
Travis-CI configuration), because maintainers do not have to remember
to update the configuration file for GitHub Actions.

If you prefer using fixed Ubuntu versions (or even several Ubuntu
versions!), the configuration can be modified accordingly.

 .github/workflows/run_tests.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
index d889b5d55604..ef4be8afc02f 100644
--- a/.github/workflows/run_tests.yml
+++ b/.github/workflows/run_tests.yml
@@ -24,7 +24,6 @@ jobs:
           # Test several Ruby versions with the latest Python version
           - {python: 3.9, ruby: 2.6}
           - {python: 3.9, ruby: 2.5}
-          - {python: 3.9, ruby: 2.4}
         exclude:
           - compiler: clang
             python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix
  2020-12-06 22:56 ` [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix Nicolas Iooss
@ 2020-12-07 16:42   ` William Roberts
  0 siblings, 0 replies; 5+ messages in thread
From: William Roberts @ 2020-12-07 16:42 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: SElinux list

On Sun, Dec 6, 2020 at 4:59 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> When migrating to Ubuntu 20.04, Ruby 2.4 is no longer available. As the
> migration of "ubuntu-latest" to Ubuntu 20.04 is coming soon, according
> to https://github.com/actions/virtual-environments/issues/1816, remove
> it now.
>
> Moreover the support of Ruby 2.4 ended a few months ago, so there is no
> point at supporting bindings (and testing them) for this version:
> https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> ---
>
> I hit this on https://github.com/fishilico/selinux/runs/1507627386?check_suite_focus=true
> and the fix is simple.
> I would like to keep using ubuntu-latest image in order to benefit from
> automatic "LTS upgrade" when they become available. I find it better
> than having to update the Ubuntu version by hand (like was done for the
> Travis-CI configuration), because maintainers do not have to remember
> to update the configuration file for GitHub Actions.
>
> If you prefer using fixed Ubuntu versions (or even several Ubuntu
> versions!), the configuration can be modified accordingly.
>
>  .github/workflows/run_tests.yml | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
> index d889b5d55604..ef4be8afc02f 100644
> --- a/.github/workflows/run_tests.yml
> +++ b/.github/workflows/run_tests.yml
> @@ -24,7 +24,6 @@ jobs:
>            # Test several Ruby versions with the latest Python version
>            - {python: 3.9, ruby: 2.6}
>            - {python: 3.9, ruby: 2.5}
> -          - {python: 3.9, ruby: 2.4}
>          exclude:
>            - compiler: clang
>              python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
> --
> 2.29.2
>

ack

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] GitHub Actions: upgrade to Python 3.9
  2020-12-06 22:56 [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 Nicolas Iooss
  2020-12-06 22:56 ` [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix Nicolas Iooss
@ 2020-12-07 16:43 ` William Roberts
  2020-12-09 21:43   ` Nicolas Iooss
  1 sibling, 1 reply; 5+ messages in thread
From: William Roberts @ 2020-12-07 16:43 UTC (permalink / raw)
  To: Nicolas Iooss; +Cc: SElinux list

On Sun, Dec 6, 2020 at 4:58 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> ---
>  .github/workflows/run_tests.yml | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
> index 6f280de8ff4d..d889b5d55604 100644
> --- a/.github/workflows/run_tests.yml
> +++ b/.github/workflows/run_tests.yml
> @@ -10,25 +10,26 @@ jobs:
>        matrix:
>          compiler: [gcc, clang]
>          python-ruby-version:
> -          - {python: 3.8, ruby: 2.7}
> -          - {python: 3.8, ruby: 2.7, other: test-flags-override}
> -          - {python: 3.8, ruby: 2.7, other: test-debug}
> -          - {python: 3.8, ruby: 2.7, other: linker-bfd}
> -          - {python: 3.8, ruby: 2.7, other: linker-gold}
> +          - {python: 3.9, ruby: 2.7}
> +          - {python: 3.9, ruby: 2.7, other: test-flags-override}
> +          - {python: 3.9, ruby: 2.7, other: test-debug}
> +          - {python: 3.9, ruby: 2.7, other: linker-bfd}
> +          - {python: 3.9, ruby: 2.7, other: linker-gold}
>            # Test several Python versions with the latest Ruby version
> +          - {python: 3.8, ruby: 2.7}
>            - {python: 3.7, ruby: 2.7}
>            - {python: 3.6, ruby: 2.7}
>            - {python: 3.5, ruby: 2.7}
>            - {python: pypy3, ruby: 2.7}
>            # Test several Ruby versions with the latest Python version
> -          - {python: 3.8, ruby: 2.6}
> -          - {python: 3.8, ruby: 2.5}
> -          - {python: 3.8, ruby: 2.4}
> +          - {python: 3.9, ruby: 2.6}
> +          - {python: 3.9, ruby: 2.5}
> +          - {python: 3.9, ruby: 2.4}
>          exclude:
>            - compiler: clang
> -            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-bfd}
> +            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
>            - compiler: clang
> -            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-gold}
> +            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-gold}
>
>      steps:
>      - uses: actions/checkout@v2
> --
> 2.29.2
>

ack

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] GitHub Actions: upgrade to Python 3.9
  2020-12-07 16:43 ` [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 William Roberts
@ 2020-12-09 21:43   ` Nicolas Iooss
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Iooss @ 2020-12-09 21:43 UTC (permalink / raw)
  To: William Roberts; +Cc: SElinux list

On Mon, Dec 7, 2020 at 5:43 PM William Roberts <bill.c.roberts@gmail.com> wrote:
>
> On Sun, Dec 6, 2020 at 4:58 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> > ---
> >  .github/workflows/run_tests.yml | 21 +++++++++++----------
> >  1 file changed, 11 insertions(+), 10 deletions(-)
> >
> > diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
> > index 6f280de8ff4d..d889b5d55604 100644
> > --- a/.github/workflows/run_tests.yml
> > +++ b/.github/workflows/run_tests.yml
> > @@ -10,25 +10,26 @@ jobs:
> >        matrix:
> >          compiler: [gcc, clang]
> >          python-ruby-version:
> > -          - {python: 3.8, ruby: 2.7}
> > -          - {python: 3.8, ruby: 2.7, other: test-flags-override}
> > -          - {python: 3.8, ruby: 2.7, other: test-debug}
> > -          - {python: 3.8, ruby: 2.7, other: linker-bfd}
> > -          - {python: 3.8, ruby: 2.7, other: linker-gold}
> > +          - {python: 3.9, ruby: 2.7}
> > +          - {python: 3.9, ruby: 2.7, other: test-flags-override}
> > +          - {python: 3.9, ruby: 2.7, other: test-debug}
> > +          - {python: 3.9, ruby: 2.7, other: linker-bfd}
> > +          - {python: 3.9, ruby: 2.7, other: linker-gold}
> >            # Test several Python versions with the latest Ruby version
> > +          - {python: 3.8, ruby: 2.7}
> >            - {python: 3.7, ruby: 2.7}
> >            - {python: 3.6, ruby: 2.7}
> >            - {python: 3.5, ruby: 2.7}
> >            - {python: pypy3, ruby: 2.7}
> >            # Test several Ruby versions with the latest Python version
> > -          - {python: 3.8, ruby: 2.6}
> > -          - {python: 3.8, ruby: 2.5}
> > -          - {python: 3.8, ruby: 2.4}
> > +          - {python: 3.9, ruby: 2.6}
> > +          - {python: 3.9, ruby: 2.5}
> > +          - {python: 3.9, ruby: 2.4}
> >          exclude:
> >            - compiler: clang
> > -            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-bfd}
> > +            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
> >            - compiler: clang
> > -            python-ruby-version: {python: 3.8, ruby: 2.7, other: linker-gold}
> > +            python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-gold}
> >
> >      steps:
> >      - uses: actions/checkout@v2
> > --
> > 2.29.2
> >
>
> ack

Thanks, I applied these two patches.

Nicolas


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-09 21:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-06 22:56 [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 Nicolas Iooss
2020-12-06 22:56 ` [PATCH 2/2] GitHub Actions: drop Ruby 2.4 from matrix Nicolas Iooss
2020-12-07 16:42   ` William Roberts
2020-12-07 16:43 ` [PATCH 1/2] GitHub Actions: upgrade to Python 3.9 William Roberts
2020-12-09 21:43   ` Nicolas Iooss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).