Re: [PATCH 1/1] Add configuration to build and run tests in GitHub Actions

[Nicolas Iooss <nicolas.iooss@m4x.org>]

On Wed, Nov 25, 2020 at 4:43 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> On Tue, Nov 24, 2020 at 8:51 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
> > Copy the tests that are currently run on Travis CI, in order to no
> > longer depends on Travis CI.
>
> s/dependes/depend/, but that can be fixed up when applying.
>
> >
> > For more context: Travis-CI is changing its offer, as documented in
> > https://docs.travis-ci.com/user/migrate/open-source-repository-migration
> > and SELinuxProject moved to https://travis-ci.com
> > https://lore.kernel.org/selinux/CAFqZXNspH6MmB-o0wtJJwj-p0DKKrH-ZjfW2YkF_yQS_gCBwqQ@mail.gmail.com/T/#t
> >
> > Unfortunately the credits for opensource projects are quite limited, and
> > require interaction with Travis CI support (which was quite unresponsive
> > when I contacted them for other opensource projects I am maintaining).
> >
> > Create a configuration for Github Actions that duplicates most Travis CI
> > checks.
> >
> > * macOS check has not yet been converted, but GitHub Actions support
> >   this platform so this can be done in another patch (and in another
> >   configuration in .github/workflows ?).
> >
> > * KVM support is not available on GitHub Actions so running SELinux
> >   testsuite in a Fedora VM is not possible. This is a known issue
> >   (https://github.com/actions/virtual-environments/issues/183) and other
> >   projects seem to face the same issue (for example
> >   https://github.com/opencontainers/runc/issues/2670).
>
> It's not technically impossible, but when I tried to run the testsuite
> in a VM without virtualization in GH actions, it was very very slow,
> so practically it is infeasible. IIRC when I tried it, it didn't even
> install all dependencies after half an hour...
>
> >
> > This configuration has been tested on
> > https://github.com/fishilico/selinux/actions/runs/380579153
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> > ---
> >  .github/workflows/run_tests.yml | 189 ++++++++++++++++++++++++++++++++
> >  1 file changed, 189 insertions(+)
> >  create mode 100644 .github/workflows/run_tests.yml
>
> LGTM, thank you for doing this!
>
> Acked-by: Ondrej Mosnacek <omosnace@redhat.com>

And merged. Thanks!
Nicolas