From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94F9EEAA69 for ; Thu, 14 Sep 2023 19:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbjINTfp (ORCPT ); Thu, 14 Sep 2023 15:35:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231476AbjINTfl (ORCPT ); Thu, 14 Sep 2023 15:35:41 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4BC26B5 for ; Thu, 14 Sep 2023 12:35:37 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-76f18e09716so85844185a.2 for ; Thu, 14 Sep 2023 12:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1694720136; x=1695324936; darn=vger.kernel.org; h=in-reply-to:references:subject:to:from:message-id:date:from:to:cc :subject:date:message-id:reply-to; bh=Bhzt7woUu7b+LnfC6SMihfQRxp2ROfPzJT4I0mUPjCU=; b=SouEFi6Pa8vVFKo4FoE2TYQdM/SBebI+6NNJ0k9OlepaFMqnqPCvpXPKqyk31Yga+h oFpxOqcFifRufbYtnrPDQR1al+vaGWD7yprk3r7NKKZAR8avw9E+345hw8KzAdEc/e70 p7FWngYzF6qPN5uAbiaALJ1gYXSSqT+CrWPSn9PImSwQ8fxMm/WnraGkPxTTAUIxiMWj 6HM2eDU8d2yjuTH/Jw+UoRS42C78N/gsjXCtKjC4YSIKokYOoS5cN2JSRDXRmFrFm2lM xKxcO0Qsj1WWdMIw1UHOGjiqKYq1UxpRNHR+yW5yGrpePZ14DS7QhcR/qv8JOrbXNNvk mB+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694720136; x=1695324936; h=in-reply-to:references:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bhzt7woUu7b+LnfC6SMihfQRxp2ROfPzJT4I0mUPjCU=; b=KQ1vf5eFQrRqqK9mL7HlgycTHq68ui4jnl1b0gYCgcff4kny7oST2mrftVu7jzXJxd SnhiBJRSkEsbtY9NNplLby+/NZQstnWKraG+Y13rlauDf0GeHfD7bZmX1fstP9eRVpbK xrHOVVGF6WXxucGg0dtKBNRNxbWUE1DBNSb9wknlgw8Qx1UiwX60zNAuHBElQAIGHNHg mohn9+dS6O3yI4CXrpFVKfou9Djv0AxAao5Vs5Q2tS/nDH0pLpDhKIQNM9yYvqSSGolY b/ymEdEbzOzE250rvWx4ZpEjvVcwZFBRTNcIxkt9swc4+DOmuomLut8jVbl0EbMkhN8F Z20g== X-Gm-Message-State: AOJu0Yzm1GKcb3KTa5ZT6c8zS3AqIvqYe2YPDRXuUIicga0xSjVXHn6L Qaxa2LHFALckTiNyDS5+GqNQ X-Google-Smtp-Source: AGHT+IFf+Btkyt3Zj3w+He3Gu0o8QU6bctV9HMlyovOVbOfHa4yuylmXr8fH+j6V8C936k23RSue5w== X-Received: by 2002:a05:620a:4728:b0:76e:eeaa:a06e with SMTP id bs40-20020a05620a472800b0076eeeaaa06emr7273564qkb.4.1694720136248; Thu, 14 Sep 2023 12:35:36 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id p9-20020a05620a132900b0077241440be8sm692552qkj.7.2023.09.14.12.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 12:35:35 -0700 (PDT) Date: Thu, 14 Sep 2023 15:35:35 -0400 Message-ID: From: Paul Moore To: Khadija Kamran , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Smalley , Eric Paris , selinux@vger.kernel.org, ztarkhani@microsoft.com, alison.schofield@intel.com Subject: Re: [PATCH] lsm: constify 'sb' parameter in security_sb_kern_mount() References: In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Aug 23, 2023 Khadija Kamran wrote: > > The "sb_kern_mount" hook has implementation registered in SELinux. > Looking at the function implementation we observe that the "sb" > parameter is not changing. > > Mark the "sb" parameter of LSM hook security_sb_kern_mount() as "const" > since it will not be changing in the LSM hook. > > Signed-off-by: Khadija Kamran > --- > include/linux/lsm_hook_defs.h | 2 +- > include/linux/security.h | 2 +- > security/security.c | 2 +- > security/selinux/hooks.c | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) Merged into lsm/next, thanks! -- paul-moore.com