SELinux Security Module development
 help / color / mirror / Atom feed
From: Petr Lautrbach <plautrba@redhat.com>
To: SELinux <selinux@vger.kernel.org>
Subject: RFC: introduce new library versions for added symbols
Date: Thu, 10 Jan 2019 18:57:35 +0100	[thread overview]
Message-ID: <pjdmuo8fl9s.fsf@redhat.com> (raw)

I used abi-compliance-checker [1] and compared the latest sources 
with 2.8 release [2].
It looks like there's one symbol added to audit2why.so.

Then I tried the same thing with 2.7 [3] and 2.6 [4] and noticed 
that
there were added new symbols even to LIBSEMANAGE_1.0 while since 
2.3
there's already LIBSEMANAGE_1.1.
It's a bug which breaks automatic dependency checking. So I 
propose
to fix symbol version mappings in order to be in relation with the
release where they was introduced, e.g. for libsemanage:

diff --git a/libsemanage/src/libsemanage.map 
b/libsemanage/src/libsemanage.map
index 02036696..45e90215 100644
--- a/libsemanage/src/libsemanage.map
+++ b/libsemanage/src/libsemanage.map
@@ -18,8 +18,6 @@ LIBSEMANAGE_1.0 {
          semanage_root;
          semanage_user_*; semanage_bool_*; semanage_seuser_*;
          semanage_iface_*; semanage_port_*; semanage_context_*;
-         semanage_ibpkey_*;
-         semanage_ibendport_*;
          semanage_node_*;
          semanage_fcontext_*; semanage_access_check; 
          semanage_set_create_store;
          semanage_is_connected; semanage_get_disable_dontaudit; 
          semanage_set_disable_dontaudit;
@@ -63,3 +61,19 @@ LIBSEMANAGE_1.1 {
          semanage_module_remove_key;
          semanage_set_store_root;
 } LIBSEMANAGE_1.0;
+
+LIBSEMANAGE_2.5 {
+  global:
+    semanage_module_extract;
+} LIBSEMANAGE_1.1;
+
+LIBSEMANAGE_2.7 {
+  global:
+         semanage_ibpkey_*;
+         semanage_ibendport_*;
+} LIBSEMANAGE_2.5;
+
+LIBSEMANAGE_2.8 {
+  global:
+    semanage_fcontext_list_homedirs;
+} LIBSEMANAGE_2.7;


If this is acceptable, I would prepare a patch with symbol 
versions
starting with 2.5 as LIBSEMANAGE_1.1 was introduced in 2.4.

[1] http://lvc.github.io/abi-compliance-checker/
[2] 
https://plautrba.fedorapeople.org/selinux/compat_reports/2.8_to_2.9-rc0/compat_report.html
[3] 
https://plautrba.fedorapeople.org/selinux/compat_reports/2.7_to_2.9-rc0/compat_report.html
[4] 
https://plautrba.fedorapeople.org/selinux/compat_reports/2.6_to_2.9-rc0/compat_report.html

Petr

             reply	other threads:[~2019-01-10 17:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 17:57 Petr Lautrbach [this message]
2019-01-10 18:13 ` RFC: introduce new library versions for added symbols Stephen Smalley
2019-01-11 12:24   ` Petr Lautrbach
2019-01-11 16:01     ` Stephen Smalley
2019-01-15 13:36       ` [PATCH] libselinux/audit2why.so: Filter out non-python related symbols Petr Lautrbach
2019-01-15 13:57         ` Stephen Smalley
2019-01-17 14:18         ` Stephen Smalley
2019-01-17 14:33           ` Stephen Smalley
2019-01-21 12:15             ` Petr Lautrbach
2019-01-24 11:09               ` Petr Lautrbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pjdmuo8fl9s.fsf@redhat.com \
    --to=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox