From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com ([209.85.208.66]:46756 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbeG3SMg (ORCPT ); Mon, 30 Jul 2018 14:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y9xuj6111Tq3UyFTcs67FeqgtWKuzXObmbGoHK8s/vM=; b=HyQPIQW2gdXdIzDp2IKHRVvILaT2Gg7NQ7IucW1RZwxScy7O9Fx3IUiT5f4FwZviIp OkW27H7L32wGkUqA9NnSICtn7b3adlSQKaL/o49gdb2z6anO2/GOmq/yFObcP8hw0fgk VTzmj4qmCD3NTQSvrwPyYpMFMxYORKF4FsQpO9FraL/WMLkYlft6vJH01Q7bakOhnJa7 ImySOy1cfa9LhXSHkZgBtRzOpJq/QLisw3H1v5RykwAB5zdiX1Bg5CP8DSYi5yFmKF7F oj4iqrfe6NHw+4WethDhdvyWkz3qQVRymp1be9IdEU9aiswOQPu7e9CF87gR2W31PgA1 KVlA== From: Luc Van Oostenryck Subject: [PATCH 1/3] mode keywords don't need MOD_{CHAR,LONG,...} Date: Mon, 30 Jul 2018 18:34:38 +0200 Message-Id: <20180730163440.2303-2-luc.vanoostenryck@gmail.com> In-Reply-To: <20180730163440.2303-1-luc.vanoostenryck@gmail.com> References: <32158e28-2ee8-f2b9-2d66-77c8eb43b5b5@amazon.de> <20180730163440.2303-1-luc.vanoostenryck@gmail.com> Sender: smatch-owner@vger.kernel.org List-ID: To: linux-sparse@vger.kernel.org Cc: smatch@vger.kernel.org, Norbert Manthey , Dan Carpenter , Luc Van Oostenryck The keywords for modes (SI, DI, ...) don't need a length modifier like MOD_CHAR or MOD_LONG as the corresponding type (and thus its length) is given by the the '.to_mode' method. Remove these modifiers from the keyword definitions, their presence while unneeded is confusing. Signed-off-by: Luc Van Oostenryck --- parse.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/parse.c b/parse.c index 270ab7bfd..0cafb4e6c 100644 --- a/parse.c +++ b/parse.c @@ -538,18 +538,18 @@ static struct init_keyword { {"__const__", NS_KEYWORD, MOD_PURE, .op = &attr_mod_op }, { "__mode__", NS_KEYWORD, .op = &mode_op }, - { "QI", NS_KEYWORD, MOD_CHAR, .op = &mode_QI_op }, - { "__QI__", NS_KEYWORD, MOD_CHAR, .op = &mode_QI_op }, - { "HI", NS_KEYWORD, MOD_SHORT, .op = &mode_HI_op }, - { "__HI__", NS_KEYWORD, MOD_SHORT, .op = &mode_HI_op }, - { "SI", NS_KEYWORD, .op = &mode_SI_op }, - { "__SI__", NS_KEYWORD, .op = &mode_SI_op }, - { "DI", NS_KEYWORD, MOD_LONGLONG, .op = &mode_DI_op }, - { "__DI__", NS_KEYWORD, MOD_LONGLONG, .op = &mode_DI_op }, - { "TI", NS_KEYWORD, MOD_LONGLONGLONG, .op = &mode_TI_op }, - { "__TI__", NS_KEYWORD, MOD_LONGLONGLONG, .op = &mode_TI_op }, - { "word", NS_KEYWORD, MOD_LONG, .op = &mode_word_op }, - { "__word__", NS_KEYWORD, MOD_LONG, .op = &mode_word_op }, + { "QI", NS_KEYWORD, .op = &mode_QI_op }, + { "__QI__", NS_KEYWORD, .op = &mode_QI_op }, + { "HI", NS_KEYWORD, .op = &mode_HI_op }, + { "__HI__", NS_KEYWORD, .op = &mode_HI_op }, + { "SI", NS_KEYWORD, .op = &mode_SI_op }, + { "__SI__", NS_KEYWORD, .op = &mode_SI_op }, + { "DI", NS_KEYWORD, .op = &mode_DI_op }, + { "__DI__", NS_KEYWORD, .op = &mode_DI_op }, + { "TI", NS_KEYWORD, .op = &mode_TI_op }, + { "__TI__", NS_KEYWORD, .op = &mode_TI_op }, + { "word", NS_KEYWORD, .op = &mode_word_op }, + { "__word__", NS_KEYWORD, .op = &mode_word_op }, }; -- 2.18.0