From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <smatch-owner@vger.kernel.org>
Received: from userp2120.oracle.com ([156.151.31.85]:51250 "EHLO
        userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726609AbfANOwE (ORCPT
        <rfc822;smatch@vger.kernel.org>); Mon, 14 Jan 2019 09:52:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : mime-version : content-type :
 in-reply-to; s=corp-2018-07-02;
 bh=NAJ84fC0GesGNAR7TIhqo9lcQ65PrU18e4k04n/6LL0=;
 b=J92C9SYBvImk/AjxYRFo0lcJdSBpT9omOp7ylDhs8dNA8wkVHVoT5Gv/O7dBHPqm+as5
 SeA9QTgWFGk3O/LGdCHESaT0h4mYUNvKwrxby6WS62s62nEyDAXs2jy9dn2SWYiWeonK
 zgUEZ7V/oqRzQycpGm6h+B/jULJ3eJxbAZocJclU5D1/sULpN+0AcsN5fBiRTKvPFP/a
 MTreJvtpJtYAFlcjL04sSVfVlSxoRchuGG2xD/0ga2GqAaa7U9rKewkl/mXjKXn3sY7/
 PzN/2OTN8IqhS4gTJc98f1K30VT3g38gE3Lt/oBHZADtJZ7wcPBxDAr4+Ap+Q9zspgAe VQ== 
Date: Mon, 14 Jan 2019 17:51:46 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: Odd smatch issue?
Message-ID: <20190114145146.GB4482@kadam>
References: <20190111123241.GA11408@movementarian.org>
 <20190114101804.GA4482@kadam>
 <20190114124257.GA12158@movementarian.org>
 <20190114143800.GF4504@kadam>
 <20190114144736.GA14913@movementarian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190114144736.GA14913@movementarian.org>
Sender: smatch-owner@vger.kernel.org
List-ID: <smatch.vger.kernel.org>
To: John Levon <levon@movementarian.org>
Cc: smatch@vger.kernel.org

On Mon, Jan 14, 2019 at 02:47:36PM +0000, John Levon wrote:
> On Mon, Jan 14, 2019 at 05:38:00PM +0300, Dan Carpenter wrote:
> 
> > Try this patch?
> 
> With both applied, smatch now catches the bad code, thanks!
> 
> Time to run it across everything...

Very lightly tested, btw.  Especially patch 2 might have subtle side
effects.  Probably good ones.  Or maybe no side effects...

regards,
dan carpenter