public inbox for smatch@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Murray <andrew.murray@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, Catalin.Marinas@arm.com
Cc: smatch@vger.kernel.org
Subject: [RFC PATCH 6/7] smdb.py: filter out __untagged from find_tagged results
Date: Mon,  7 Oct 2019 16:35:44 +0100	[thread overview]
Message-ID: <20191007153545.23231-7-andrew.murray@arm.com> (raw)
In-Reply-To: <20191007153545.23231-1-andrew.murray@arm.com>

The find_tagged command lists call sites that may lead to a tagged
pointer detection deeper in the call tree - let's filter out any
that we know to be annotated with __untagged.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 smatch_data/db/smdb.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/smatch_data/db/smdb.py b/smatch_data/db/smdb.py
index ba46b01a4d08..04bff00be45a 100755
--- a/smatch_data/db/smdb.py
+++ b/smatch_data/db/smdb.py
@@ -574,6 +574,12 @@ def rl_is_tagged(txt):
 
     return 1
 
+def rl_is_treat_untagged(txt):
+    if "[u]" in txt:
+        return 1;
+
+    return 0
+
 def parse_warns_tagged(filename):
     proc = subprocess.Popen(['cat %s | grep "potentially tagged" | sort | uniq' %(filename)], shell=True, stdout=subprocess.PIPE)
     while True:
@@ -622,6 +628,8 @@ def find_tagged(func, param, caller_call_id, printed):
         for row in cur:
             if not rl_is_tagged(row[2]):
                 continue
+	    if rl_is_treat_untagged(row[2]):
+	        continue
             found = 1
             if row[1] not in callers:
                 callers[row[1]] = {}
-- 
2.21.0

  parent reply	other threads:[~2019-10-07 15:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 15:35 [RFC PATCH 0/7] Tagged Pointer Detection Andrew Murray
2019-10-07 15:35 ` [RFC PATCH 1/7] build: Add '-lm' build flag Andrew Murray
2019-10-07 15:35 ` [RFC PATCH 2/7] smdb.py: remove undocumented test command Andrew Murray
2019-10-07 15:35 ` [RFC PATCH 3/7] arm64: add check for comparison against tagged address Andrew Murray
2019-10-07 15:49   ` Andrew Murray
2019-12-04 15:41     ` Andrew Murray
2019-12-05 13:27     ` Dan Carpenter
2019-12-05 14:28       ` Dan Carpenter
2019-12-05 14:35         ` Dan Carpenter
2019-12-05 17:21           ` Luc Van Oostenryck
2019-12-05 17:24         ` Luc Van Oostenryck
2019-10-07 15:35 ` [RFC PATCH 4/7] smdb.py: add find_tagged and parse_warns_tagged commands Andrew Murray
2019-10-07 15:52   ` Andrew Murray
2019-10-07 15:35 ` [RFC PATCH 5/7] kernel_user_data: track parameter __untagged annotations Andrew Murray
2019-10-07 15:55   ` Andrew Murray
2019-12-05 15:04     ` Dan Carpenter
2019-10-08  8:24   ` Dan Carpenter
2019-10-08  8:41     ` Andrew Murray
2019-10-07 15:35 ` Andrew Murray [this message]
2019-10-07 15:35 ` [RFC PATCH 7/7] Documentation: add guide for tagged addresses Andrew Murray
2019-10-08  8:58 ` [RFC PATCH 0/7] Tagged Pointer Detection Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007153545.23231-7-andrew.murray@arm.com \
    --to=andrew.murray@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=smatch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox