From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [8.12.47.4] ([8.12.47.4]:4674 "EHLO jlevon" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726891AbgELNlb (ORCPT ); Tue, 12 May 2020 09:41:31 -0400 From: john.levon@joyent.com Subject: [PATCH] Check for NULL stmt in check_all_func_returns Date: Tue, 12 May 2020 06:23:48 -0700 Message-Id: <20200512132349.26073-1-john.levon@joyent.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: smatch-owner@vger.kernel.org List-ID: To: smatch@vger.kernel.org Cc: John Levon , Toomas Soome From: John Levon Sometimes, there's nothing on the statement stack. Signed-off-by: John Levon Suggested-by: Toomas Soome --- check_all_func_returns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check_all_func_returns.c b/check_all_func_returns.c index f9d77449..1ff50433 100644 --- a/check_all_func_returns.c +++ b/check_all_func_returns.c @@ -74,7 +74,7 @@ static void check_func_return(struct expression *expr) stmt = last_ptr_list((struct ptr_list *)big_statement_stack); - if (stmt->type == STMT_EXPRESSION && stmt->expression == expr) + if (stmt && stmt->type == STMT_EXPRESSION && stmt->expression == expr) sm_error("unchecked function return '%s'", expr_to_str(expr->fn)); } -- 2.23.0