From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:22286 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244832AbhGLHdS (ORCPT ); Mon, 12 Jul 2021 03:33:18 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16C7L3U7002583 for ; Mon, 12 Jul 2021 07:30:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=QG4Q7SWK0JypIigpsEFQEqnWd9Vgh+ySKo5JOimB0DI=; b=uWlJ4aG1a0p+Kq3T8C/SYd5FlDNpJaxLmxlj51AbQBSSgJmrna/gfLW22OlsMSKzAxNX 2zyE0FRbvi5Qqg6Rgl3Suh6s6sBn9aGZQuncTJGc2uf2atlZrHHuqx9Z2qIyLSm5nUHs 60v2dSES/g7WQnJy0LKNs5AJkO+7Jy0kaxsHK1eAQ23Si6CF9StSWFBYD7LMybPSG78o y2vk0lNMvDVM2KR7sM2WXG19l+i82leyvnlTLpm0460QY3FfXEd5lzNeb4Kf6qMCukrB 4xabncuoMsn/aBmGlyl+6j6pqVKR7jvin8klvA9IWXPkRN54sS3ONMVmkXHmcGhQeIYJ Dg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39q3eaj0jv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 07:30:28 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16C7KlS0006038 for ; Mon, 12 Jul 2021 07:30:27 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by aserp3030.oracle.com with ESMTP id 39qycqhe80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 07:30:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QG4Q7SWK0JypIigpsEFQEqnWd9Vgh+ySKo5JOimB0DI=; b=h5arX62NYn24AiE7+RTpNDYOTOV4+i5pKM66P/1tQ/7YkjaveAyDh+YhW5TA2T34hRtai04cmJ25iglyGCBNxdCmMubn6gHDpCz22QBk+2mdQA1BULoaA46NbsDNOj+i1f0/v1HL7SkAr1+W5vnunwfpjnpH7CQEcYo1oUm6RI8= Date: Mon, 12 Jul 2021 10:30:06 +0300 From: Dan Carpenter Subject: Re: [PATCH] extra: Fixed false output of handle_AND_op and handle_AND_condition Message-ID: <20210712073006.GA1954@kadam> References: <20210710205047.11596-1-harshvardhan.jha@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210710205047.11596-1-harshvardhan.jha@oracle.com> MIME-Version: 1.0 List-ID: To: Harshvardhan Jha Cc: smatch@vger.kernel.org On Sun, Jul 11, 2021 at 02:20:47AM +0530, Harshvardhan Jha wrote: > - set_extra_expr_true_false(var, > - true_rl ? alloc_estate_rl(true_rl) : NULL, > - false_rl ? alloc_estate_rl(false_rl) : NULL); > + > + sval.uvalue = 1ULL << (ffsll(known.uvalue) - 1); > + bits_expr = value_expr_sval(sval); ^^^^^^^^^^^^^^^ Ugh. Actually you forgot to send me this part of the patch so it doesn't compile. Please resend. regards, dan carpenter