From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:48176 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbhGLMuA (ORCPT ); Mon, 12 Jul 2021 08:50:00 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16CClBY2001236 for ; Mon, 12 Jul 2021 12:47:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=UqXlRHtIV31kccrrnTzRUyuMNofd1OKIm0vbmqQkEu4=; b=c6C+gm6mtQknDC4vMpDA5zb1EKorKzOFIjARhSmgCGlF4R0midiCK17Wv7ZBR7P1C7Gj 1j48kHiFvdE9Elu6/VDhbXr98jMZ0gPrqou/KxpZUpLUhQ+kmKigUHrknDvDb3bhcIyz NEX/uUDDP81dxvfQ1ZADhb1Sa1mJtPFs88YnwCzklZIs0pmk876TOuJGfztkvfcRW/2D GagGYvD4Jv9ad1v5owNqGma2sdfRcZkF5LyYeDpoxrmyBB2MVsciczfwUDASipA5Jcy1 pqbgQUlRWv43+w/7ByNYcgLea0V4hD/gvev8BrRbBnvGTggWuEIDG+0aEZgTtEDP4sxG Vw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39rnxdg0ft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 12:47:11 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16CCinbZ024081 for ; Mon, 12 Jul 2021 12:47:08 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by aserp3030.oracle.com with ESMTP id 39qycrjdqp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 12:47:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqXlRHtIV31kccrrnTzRUyuMNofd1OKIm0vbmqQkEu4=; b=Xok8b6JwC2MbRXXs0SFTkZ2tRftYds1tvZkV5TO4LXDKq5CeyB4FkIqi8Wo5XyL70XYITVc0zOJjDXOhctZ3EL3TZeD9MuOOY43lVzdx7J6PtadP8ZE4B7BYiDZ5DT8GyJYDPj5NJjWdCSg7xmnU0k+HH8jhwYEMpmZ9DdvlevM= Date: Mon, 12 Jul 2021 15:46:49 +0300 From: Dan Carpenter Subject: Re: [PATCH 1/2] extra: Fix false output of handle_AND_op and handle_AND_condition Message-ID: <20210712124648.GF1931@kadam> References: <20210712123947.24116-1-harshvardhan.jha@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712123947.24116-1-harshvardhan.jha@oracle.com> MIME-Version: 1.0 List-ID: To: Harshvardhan Jha Cc: smatch@vger.kernel.org On Mon, Jul 12, 2021 at 06:09:46PM +0530, Harshvardhan Jha wrote: > handle_AND_condition and handle_AND_op gave false outputs. This could be > seen in the test case in validation/sm_bits1.c the expected output was > 0x1 for possible and 0x0 for definitely set. However, in the previous > state 0x0 was output for both possibly set and definitely set. > > Signed-off-by: Harshvardhan Jha > --- > smatch_expressions.c | 10 ++++++ > smatch_extra.c | 72 +++++++++---------------------------------- > validation/sm_bits1.c | 23 ++++++++++++++ We need the smatch_extra.h part as well. regards, dan carpenter