From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:35054 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234320AbhGLNEG (ORCPT ); Mon, 12 Jul 2021 09:04:06 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16CCxAAM016834 for ; Mon, 12 Jul 2021 13:01:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=y/GNao7Bfiu9wNkYgwa5eGAU3Ih9qQzBhc1W11/SOi0=; b=n4VgKwr/Wsx//dnTNMF+BGBi0Z6SSPkQH3W3juljv/7TxFUG23snPgEw+DhvdZk7/sjW FjpgBcPdpop7xclcNrFX6gl4n+n07VDK2alO/2Ud23kwXiKswfeWz3i1h2/0wkv1tJw6 Wfmw36G47iWhuUNj+dZ0uwQC4TMHZR+6kJ5Fxl4+uqGnHr26zf78kHJ7QkGegSVcSo47 hIXoZoKB/170VFalrrnzoHKxWSUV3+OLKOL1jfC4kuvO2WN+YaFMrET9RPWDGHLybMLT UGkwouQFrHsLYDCMVgZerw2gGoS2kSDj9drhYcWp86NbG/wrWytUJbP1HMO8ZHgC7cWm lA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39rnxdg1cb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 13:01:17 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16CD0QeO111398 for ; Mon, 12 Jul 2021 13:01:16 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by userp3030.oracle.com with ESMTP id 39q0p04n6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Jul 2021 13:01:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/GNao7Bfiu9wNkYgwa5eGAU3Ih9qQzBhc1W11/SOi0=; b=Y9buymMSQO9f7SR2N1rjMJgqov7Sl18y48ll+uT57uXxa6oNYvt/V+SKJx9tLlqMd0NEFLh+BkV6PwTOW1Le3HXK5s884b+a+alDAfGeE2omQJCDhlib+LSmu+Bb/NQFxtL6D20E+zvKGT9uHLpFc0LNUJL7Zxs2REe4S9lkvDg= Date: Mon, 12 Jul 2021 16:00:56 +0300 From: Dan Carpenter Subject: Re: [PATCH 1/2] extra: Fix false output of handle_AND_op and handle_AND_condition Message-ID: <20210712130056.GD1954@kadam> References: <20210712125428.30186-1-harshvardhan.jha@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712125428.30186-1-harshvardhan.jha@oracle.com> MIME-Version: 1.0 List-ID: To: Harshvardhan Jha Cc: smatch@vger.kernel.org On Mon, Jul 12, 2021 at 06:24:27PM +0530, Harshvardhan Jha wrote: > handle_AND_condition and handle_AND_op gave false outputs. This could be > seen in the test case in validation/sm_bits1.c the expected output was > 0x1 for possible and 0x0 for definitely set. However, in the previous > state 0x0 was output for both possibly set and definitely set. > > Signed-off-by: Harshvardhan Jha > --- > smatch_extra.c | 72 +++++++++---------------------------------- > smatch_extra.h | 1 + > validation/sm_bits1.c | 23 ++++++++++++++ We've got the .h now but not the smatch_expressions.c file. ;) regards, dan carpenter