From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2AE83A4514 for ; Tue, 7 Apr 2026 16:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775578612; cv=none; b=RVc4G1SiVVQJs39nrnnNIg1yzEMUrfoWeYsA8w+aOzXhNq8zQqpMk9+sI+b86nUx5Ch7ZgYUa0JswPzTMG9c4oZKQnI7xGnsSsRoUq805oywsDtFbYYFQyLx8Xu9m9HAjPIYj0yJiDlPoQGU7ysxuYSsYLB3PHQ3aHwP5rWqEjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775578612; c=relaxed/simple; bh=N7B2NRNrCcoCZXRCzCluA6pyLrfFfgDYHtbKW5TrVlk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:Cc:To; b=D7l/1JP3yZZj+7qaA+3dpHcRpGPgfBAF/ozAe4hvGzO6lwaGwWSGnsuPsvI6fRxBXb1OYGFjSfmDifTE4CYQbPQ2VREljXSrtocoEOm75ZvXdqTcXi7bOdehxvXYeooBnQS9qmwPSst9KdaNF3seFs8mpvivFAzmP7AePzxpuu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJvpwA6i; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJvpwA6i" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-64ef161129bso4286270d50.1 for ; Tue, 07 Apr 2026 09:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775578611; x=1776183411; darn=vger.kernel.org; h=to:cc:from:subject:message-id:date:content-transfer-encoding :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cb8JN+CcKXyEgZDCd+oR4CHR7ekowZmPhJnr6+x976U=; b=hJvpwA6ioGtOCRI4qJ057iNQpjylxScEPiZVKVwduTlUpqQ7KS/aVJSGXRzfUMFSGV KxSMshzj7dSmw788UtSB9TDis27ySDWIDwKmXnKg/eJMsGNhZDGkLhWfcBprjf9E436i u6m9v5dzIRFJaTMk08rWENSDUt+i2cUqYz4aKcrzRqZRPxYm2fWVUSeXCTW+uE69lKt5 MET1NwwjbjNgfc/6R/kCLpUA/gVrGoSRnZtqj6jmbKa9P7p5quXDP+Mk8tEvn5DVf6p3 cxTzb/HManzVngeNWByPa6V/zQPA6oPtC0+qLnVdsJFEM7xj+wbv3weq1NNf8fgYULkV JIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775578611; x=1776183411; h=to:cc:from:subject:message-id:date:content-transfer-encoding :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cb8JN+CcKXyEgZDCd+oR4CHR7ekowZmPhJnr6+x976U=; b=lAuei1eWZp1p7Y9gByTzy+iPWfAsy/GuZ/9VQRT5o+PJ0d/CLTtLiPtkZ8/vVGq7Rs uYLKPXac8eeup4OpT0LOEZpw0brtOuU4pjVksOFfXcaC6CXgvdt5t0XM5/qj2/N1JL0F TplmgBna7RrSBdWL/KdbaCycRZ5S53nRtR4YyZWVstfKFefM8cvp2/OAHgoGrDRVry2+ mI/Ma0q8P/yxEhOH/BbUr63VCKctJSgKYKSPkkdOksSjrsb+F8DIUw6/nwiw20QDGm/J Ug9/eqdCipk1Db1AAUz21stkdS2wSqKB3NwE7rRH/ePrPw3P/xoAeoFX7uvNcLFpoTwS UQxg== X-Gm-Message-State: AOJu0YyQNGbnU2NvZyZDY5uy3OGGZ4xsbB6PXSZRNq9S/04xc8v3lZJ+ vVsLaDLkQPegefLpI5xaxuD470wUFEh5XKoXVeiR5Rllp3WE8H8/uzXV X-Gm-Gg: AeBDietXEudrbH+7cpBjGs0LKrSj9QoLggt+MwvGWStFXPcez3J0a2z8Wp1BaYdoDZ1 n0K5bj3JMlcwExBOA3DXEwWpXOJ66zw5HzKV8fYe5OPfWebP+2gbcKEyknHJgOP6pDf7awQGJ2A VBNH9Es595y+7exjcH9/QZD1R3V9WYQAi1Ws7/b2GlXY3IZbafkU/66kPCuyc3zBStbk5/ymPDr CK1oU8E8SOro7kwck0DSBQ6sbbNK3HOxoSI1lvBniv6nNlQiJTxDRAIALAbFnFQc6HNhxEVTofC /DEFkhaQvZnx0tyrMCDkM09CeSsRnRLs43RrAr391LvoB9zJ99/QMyiiIfboxNg9X173n0TeTDR T+wie5oC3hInfPGPVOL3aG3y4iVo+qnm61ArdFK9DqhwEF8B6dDiqWavtifarUwkqfFtZUa76NP F8p0WwDovgKP0p46XqIijUfBpoxxTQbDe+teTmab/IW4XFQxeTTLcphqvBwUqxI9pMAwfRBNIVv 2b6jdqiRFK5YkLhDHJ/eGVutV5HDu5J X-Received: by 2002:a53:df06:0:b0:650:3064:4cf3 with SMTP id 956f58d0204a3-65048710ee0mr13410849d50.26.1775578610512; Tue, 07 Apr 2026 09:16:50 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9e916esm7934035d50.21.2026.04.07.09.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 09:16:50 -0700 (PDT) Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 07 Apr 2026 11:16:45 -0500 Message-Id: Subject: [SMATCH] Can also be NULL false positive From: "Ethan Tidmore" Cc: To: "Dan Carpenter" X-Mailer: aerc 0.21.0-0-g5549850facc2 Hi Dan, Smatch gives these two warnings:=20 drivers/gpu/drm/i915/display/intel_crtc.c:333 __intel_crtc_init() warn: 'pr= imary' can also be NULL drivers/gpu/drm/i915/display/intel_crtc.c:348 __intel_crtc_init() warn: 'pl= ane' can also be NULL if (DISPLAY_VER(display) >=3D 9) primary =3D skl_universal_plane_create(display, pipe, PLANE_1); else primary =3D intel_primary_plane_create(display, pipe); if (IS_ERR(primary)) { ret =3D PTR_ERR(primary); goto fail; } crtc->plane_ids_mask |=3D BIT(primary->id); and if (DISPLAY_VER(display) >=3D 9) plane =3D skl_universal_plane_create(display, pipe, PLANE_2 + sprite); else plane =3D intel_sprite_plane_create(display, pipe, sprite); if (IS_ERR(plane)) { ret =3D PTR_ERR(plane); goto fail; } crtc->plane_ids_mask |=3D BIT(plane->id); But, this is a false positive because skl_universal_plane_create() and intel_sprite_plane_create() never return NULL and always error pointers. Thanks, ET