From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E13FA34676F for ; Wed, 8 Apr 2026 13:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655623; cv=none; b=lw7JtOQF35NuHCjgvQUKoBCjhf281zFjq2SGHAB5xnJ3R63Dba19A42Tn5r5R58JQD/MG7a6I7QwHwJjYcazzTY2eX2bnPGGSDCwsZfnI7LrFl4r5hhXeT4cU6ljfVlYPBqQtB/LtrTaloIaYkHru1zEPkXVCGOdA3cw0ocFABM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655623; c=relaxed/simple; bh=S/0VBBxH2t3uwkY+djV4iq9XjBAJhWVkENuapgJ/iHM=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=j48A1PIqrfCZ9WhQdyoNCcNzpbOAi4G/Jmln/pjOnIJ6lgkEW8l5aGeRFKcF68bma9JVxfBY6YU/qTJiyKlLSjODgW3BZQ+ZYO0kh9v60uAfZajjUactIa6Z2Kye6VelRXPD1km2DUpMLCIPwcz4wq3Lils1r6V2mlYpR01qnj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OlPdVLrq; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OlPdVLrq" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7927261a3acso54930487b3.0 for ; Wed, 08 Apr 2026 06:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775655621; x=1776260421; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o/rrgUROsT4CqlA+105x3P6wpTDLO3r9uE0QMtfpLfg=; b=OlPdVLrqpklR+TZnexPrwqd7kp4RIbdT4IsznCeM3Mgz25cfMXHVCBoOY/syCMmv4s XzmGJEV/LOWl46D+DM4NR3k0rVH0FfRuYDjeZ3jwrp82J9yKYfuYBq7SUcrrv5HFseQN 9B3Qg/q1JufrwGBaxGk9AitWivY71uAnjjwmpJP+bkU7PtWFx4bZVh+ATLCVKIdtg38i 65prllJGOD+Lp1pEx3EidM59P+3g4HljUDYSiYZWXosL8cVhawFq/4+78+0SPkF3jnpH qpK1lXXoBsLpqJOFMvolq6LvA/nAgEj7eNeTzmqciV4QwT2l/UB5zXe/7tfC32trng4l gjVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775655621; x=1776260421; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o/rrgUROsT4CqlA+105x3P6wpTDLO3r9uE0QMtfpLfg=; b=d2NJDubQgOu9ZH2mRTdvwpSo1pF2XTWQiYDdtDmPibP+jqo7y95ufAgGZ65UoZW7Yr 24GSqVo85NbXMvn4IB4VpUtv0nemggdlmdhH4y227LqcOdzjGfZV9tbpv6HxXT0cG/TD tB9SlecbyQ2lvZICXhZSSuBP00ALdMiFU4ThIK4zfFgHe9PIbf3njAX/g0p+cCaB6XMK gyKQtrvnYIQx8GFNJYz6nT9tA1xV5toj4mIuZ8g0W5+Fv1Ibuu/qIssy4UJP7uLI19zw UDobtdSNkP9E//nCF0OS7ulgqJtk7PxeI1LD+e8tBeKVisunHMAI2al7ArtZwKTZeS9+ xX8g== X-Gm-Message-State: AOJu0YwHdTd92QYM/XOmFubIgPcv8/c8NgCvgIBmcQDe6d4HcGBYBjv1 nANlOpAPPxGtFYMCjrgFkFzC8qGIJcfVH7oxZRpvpQlTl21Bt0HffG9P+WB26Qw7 X-Gm-Gg: AeBDievo5v3ULdq2f7F5VbPzjHq56YFPjmUXPxfdTdh1wG8oHrwgwVSkNMwLyKNBt4J bpvcJhqjfocOJXHxdG0l30k70fEMSJ2E7/c7kRq0woXyqjy9SVdyE8RCNQi3aaziaWrrqfO5b16 LTrP5uWU6fAzdCIsjpEffCZV4trz2Bchxj59d8jfmL44cNEzEEAv+1uK1+GQqHAVq528M1SDOGw 2P7b15SE5t8DBf0waXBDXJOQkoyN7+tWwSM+p17VcgqZcj3aMxGYpxwGEcoCkCF1QomaVWZ1emr BHygW9l40FlXUC4SIGbguSHmkuI6yQipZDqleemKJx/6ajd04wIKw8Z5IhCYhY236Mluk7yBAZ6 jn4F+6vTukb2xL6+LaUpnRLx1cWiRdscDe312NKNtRVROUNgLyMs/A+JTHgJ7Bgem1kU3ATB04S zq/8tEPAZ0x4OjlZuwtMf9lpqJu8NvpGSkKSi4q0nFD76XgTBvomwaBiiKUv0Q0dmY6lvPkWXcA iAgWFPmRYOy5zJlhmhZfTYjxCtdg7NhvLuO5dcP8pa2+ouvSsSVxZ9AAqJwZ5Tymh1YwMaZ8I0G Vg== X-Received: by 2002:a05:690c:8e10:b0:78f:9801:7606 with SMTP id 00721157ae682-7a4d84c5bb0mr168600677b3.34.1775655620613; Wed, 08 Apr 2026 06:40:20 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360:c895:e677:bc6d:beb2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370902c15sm84924777b3.32.2026.04.08.06.40.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 06:40:20 -0700 (PDT) Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 08 Apr 2026 08:40:19 -0500 Message-Id: From: "Ethan Tidmore" To: "Dan Carpenter" , "Ethan Tidmore" Cc: Subject: Re: [SMATCH] Can also be NULL false positive X-Mailer: aerc 0.21.0 References: In-Reply-To: On Wed Apr 8, 2026 at 1:47 AM CDT, Dan Carpenter wrote: > On Tue, Apr 07, 2026 at 11:16:45AM -0500, Ethan Tidmore wrote: >> Hi Dan, >>=20 >> Smatch gives these two warnings:=20 >>=20 >> drivers/gpu/drm/i915/display/intel_crtc.c:333 __intel_crtc_init() warn: = 'primary' can also be NULL >> drivers/gpu/drm/i915/display/intel_crtc.c:348 __intel_crtc_init() warn: = 'plane' can also be NULL >>=20 >> if (DISPLAY_VER(display) >=3D 9) >> primary =3D skl_universal_plane_create(display, pipe, PLANE_1); >> else >> primary =3D intel_primary_plane_create(display, pipe); >> if (IS_ERR(primary)) { >> ret =3D PTR_ERR(primary); >> goto fail; >> } >> crtc->plane_ids_mask |=3D BIT(primary->id); >>=20 >> and >>=20 >> if (DISPLAY_VER(display) >=3D 9) >> plane =3D skl_universal_plane_create(display, pipe, PLANE_2 + sprite)= ; >> else >> plane =3D intel_sprite_plane_create(display, pipe, sprite); >> if (IS_ERR(plane)) { >> ret =3D PTR_ERR(plane); >> goto fail; >> } >> crtc->plane_ids_mask |=3D BIT(plane->id); >>=20 >> But, this is a false positive because skl_universal_plane_create() and >> intel_sprite_plane_create() never return NULL and always error pointers. > > I don't see that warning on my builds. > > One thing that I see is that intel_primary_plane_create() can return NULL > if CONFIG_I915 is disabled. But I can't see how we would build that > file without CONFIG_I915. I wondered if it might be a CONFIG_COMPILE_TES= T > thing, but I don't see that possibility. > > Do you have the cross function DB built? I'm building with 'allmodconfig' and using these smatch scripts: ./smatch/smatch_scripts/build_kernel_data.sh ./smatch/smatch_scripts/test_kernel.sh --endian Thanks, ET > > regards, > dan carpenter