From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C44236437 for ; Wed, 26 Nov 2025 12:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764159257; cv=none; b=pK/SAcuK8HetclT0GhqM885Rukr6m1nLEcc7u1otFsfGxBCvw28GCLtPIhAxDn2YorW689VGjxYhp1ZPsmL8Sda7WpfMk/HiuHwW4/wl83O+2pjxYVip9HySEf306EVFpYp6JruaVesnDpszAxcbSrxaNtokRDSC/lMgpFvHA1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764159257; c=relaxed/simple; bh=HL40ZY62iD3MDXCfAPfG4200G2QWYyEjoRbG+QiX85w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N8aFOPjBst0rwHq9JWCEexhT8UiwVC9j+oTH5FtBthJVe8olnrWcfbdQ5JQMpt03gJEdO8FJ4bW98te8KhyES332ZR8rHYjQsWjH4JK8s1/f79xmvlO2DgeA85DZrGtR85FZrCxF2GLxZ0dpvCMtUf0QiSoFM/wxNIEF0rdK1TQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qRbU2trS; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qRbU2trS" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso5679915e9.1 for ; Wed, 26 Nov 2025 04:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764159251; x=1764764051; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NsAlVMot25aZRIUhbUARJe6aknpAKDmAa6Uw4Y/iBSI=; b=qRbU2trS3EflwplvBMKQo2pepCCLiQZqgmexA18L9hJbzHbp9w6RGACYCqYEyCqkH+ 2lde8zK5In2ixwE7Snl/C+InE7KFY2zmIeXyASL61W6er4HcMfb+1d/ZTK3CWnIr6LeN wxcqj8enXQL9LI9tSALwjMTRVhS2w/TTJ6OZZla9hMbiNG51/hnigUyzyuq4V53ee+Kw +ZQJdpb4S8ruShvM2UeptN9Z0RqnVHcKAbEijfUMAFJ6eYbQ6YkGmzvm5wuAmRX1Buia cHiWnS+nJZBtP7f7TqksN60vDWZ6yUp/9mbmXkDRc7HpKuWwDNTJ2blDHTNwmOiE8kO9 eF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764159251; x=1764764051; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NsAlVMot25aZRIUhbUARJe6aknpAKDmAa6Uw4Y/iBSI=; b=k8erqs+ynFMmYPEWHYWp62nQQ/8XVeC70RbpiUwc72nRQjUN2zynbOou+UxpGfy7MM aMaC+FDQa0JHlkodJoNuSgFu/AiXKA9H9E3eI+G63JDvYVVriSMQ/wxIvmK9x1fHcaZS ub+sx+fpwYCjc6Rt1gCob6WHsM1+qSTkrnn9kgenVoSynRR7qZ2sBK+O5EvCgA8p0v0x utIlaVkk1Zxfxbr83TsDgrwhLTgyNXI4Pvs90FGizhhvI8Z1LJdkQOo/fxb8IfWvzWpT C7XTDmjI1jYWSmFUU2mCWl9u5n5XeGCLpmzD5l2JVOTtS1LYIZMCHUKWOLJmILiuoUvN sUkQ== X-Forwarded-Encrypted: i=1; AJvYcCU+tu3/tmzbkhr3MoUBxgqjQkhdsxv+9C3sDRW5085yx05Twns+VvMmpFJJQUbVWyLuGzXNipw=@vger.kernel.org X-Gm-Message-State: AOJu0YzU6+ltXrjr3sccR+VhH9jUmu3zO7RA2Bf1iGtvVkZ4qu4d7x3E 6+Z/HxPu8QdHSVbb+O9I57a84yFU+NNQ8CuHeqFVzf5/fTSX8uz1ViViF6S4IhZ7DnrwT2+RqOh 5Uo4T X-Gm-Gg: ASbGncuqzGsO1HNOrTyt6h5mqoSiEGJZjvJwka7Yg9FmASz66+WBPevXJwQWorN3jfT MwXSLWU/Fn2X1w3rK3VTSWPN30cGKVV7snyBwB4zOy0lYnwku4TP8ELh1ZmQheMZHOKxnL14H6B zlqTv8Lg4cV45oZaUih23OiK4MlLY5AL6qtOEQSJ2uHNmXCc114nldYvuCpceZQYyN1UiNNjiTR c0ZclZyYohbxv3V72I74qzC928mu8luW+T0Bk7bhAD87ChAthaOY7qPn9L1rcUDavaHZVJYv1wH NVXBs+o4wlvEH/LPSWGO/9DpS3rYeWiTFk6/ctJ4Dy1AFDBqn6Qp9HQDXYFvc3/1WMSv07c6S4O DuVcizwNH8iWjA6tCEG3Kmr2fL7ClfkRp6tRI6PTfRvwtAStUlBbbru4qhoQlKZxcRPCUkJP8gb 4acBG6UZipQc8zIBY1 X-Google-Smtp-Source: AGHT+IHLsQTht/P2QFG50TDmfIoV5ecx7+4GLKkLajP0R8jvefWjiA9oI3PxwSNYSKjMO9qmQaeG7g== X-Received: by 2002:a05:600c:1e89:b0:477:a1bb:c58e with SMTP id 5b1f17b1804b1-477c04cfddcmr210963885e9.7.1764159251493; Wed, 26 Nov 2025 04:14:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4790add608bsm41544745e9.5.2025.11.26.04.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 04:14:10 -0800 (PST) Date: Wed, 26 Nov 2025 15:14:07 +0300 From: Dan Carpenter To: Oleg Drokin Cc: Toomas Soome , smatch@vger.kernel.org Subject: Re: apparent bug about check_free_strict Message-ID: References: <7F97D3F0-18D3-4025-A6D2-74773061A56F@me.com> <9A95EC42-6BBD-4300-A8FD-0229A56347DC@me.com> <27F1E218-CB00-48C3-9515-A40ACBF05828@me.com> <7D5C8F19-CDFA-445D-B0E5-960812931C66@me.com> <29167bc23b32a76180a3f0acd60483a95e282859.camel@linuxhacker.ru> Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <29167bc23b32a76180a3f0acd60483a95e282859.camel@linuxhacker.ru> On Tue, Nov 25, 2025 at 10:34:49AM -0500, Oleg Drokin wrote: > On Tue, 2025-11-25 at 17:04 +0200, Toomas Soome wrote: > > For positive side, the current smatch has been able to detect many > > bugs the previous versions had missed - its definitely good progress. > > While there are some issues, we can disable checks on such cases. > > Only problem is that where previously —disable=check_free_strict did > > work, —disable=check_free does not seem to:) > > The way I found to be the most impactful is to just keep a database of > the warnings and then: > 1. mark the clearly invalid ones so they don't pop up again > 2. every time there's a new patch - see if anything new gets added. > > the new additions are the primary focus of new triage then since all > the old ones were presumably checked already. Yeah. This is my favorite approach too. I feel like you're more in favour of a higher false positive ratio than I am, but I do think looking at false positives one time only and then ignoring it forever is the best approach. It lets you check for more things, faster. regards, dan carpenter