From: Dan Carpenter <dan.carpenter@linaro.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: error27@gmail.com, smatch@vger.kernel.org
Subject: Re: [PATCH] smatch_scripts: Fix incomplete quoting in kchecker make command
Date: Mon, 15 Dec 2025 16:35:03 +0300 [thread overview]
Message-ID: <aUAOh4rAW5kgDcL7@stanley.mountain> (raw)
In-Reply-To: <20251215130518.3157403-1-harshit.m.mogalapalli@oracle.com>
On Mon, Dec 15, 2025 at 05:05:18AM -0800, Harshit Mogalapalli wrote:
> The previous commit added quotes around some variables and that
> caused empty string arguments when variables are unset. Use
> conditional expansion to only quote when variables are set.
>
> I see something like this
>
> $ kchecker --spammy net/ethtool/ioctl.c
> make: *** empty string invalid as file name. Stop.
>
> Fixes: 9b3323efbe7f ("kchecker: Add quotes around variables")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> I have tested it on mine with no variables set, worth testing it when
> some of these varaibles are set as well.
Thanks! Applied.
regards,
dan carpenter
prev parent reply other threads:[~2025-12-15 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 13:05 [PATCH] smatch_scripts: Fix incomplete quoting in kchecker make command Harshit Mogalapalli
2025-12-15 13:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUAOh4rAW5kgDcL7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox