From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9E4327FB3E for ; Mon, 15 Dec 2025 13:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765805712; cv=none; b=Zr21tmCD5259a1p7PMWkhfktcheJkARj1S+T0vArcPe+6PdY1+OP7wpDWM0dWIcWBf5gmlXzyfoZYas8Mi2ZsahEQgN/2gefi3iRpR05RCqw8IU2J4ME64y5fYK8lZ3HnliXbkswWuGPIWSFzyaLxKq2kPH+aPAJA0IZ8BWM7cA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765805712; c=relaxed/simple; bh=0Hwqm2wQF7cOtE9GxQE5Yh2ukxeK07dPUYFKGDIX4tk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ajfM2tsMOoEEitvkfmPKJZK3L9cyjZ6LDZ2ZoQiYOBrnrOq6mYGXapz3rsvanYozV7JEvImAn+dRXlHvExOVaX6uM7n9pUuwy9BDa7etRY48EJgHWIJqqbPvAJM7kjIHe6jtLIQi01Tzue8SfTqE6wdwR3GeC1f/FZ1yNqjMq9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qGfesb+g; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qGfesb+g" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso26290055e9.2 for ; Mon, 15 Dec 2025 05:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765805709; x=1766410509; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zFO2PKd6HO5Gu1vCpikmYG9F+M/Njg31pKSD+vidcWg=; b=qGfesb+gCwd7i031HcunE/MD2cwBia9mPobCRjCDrn76vY5Ez+y1JgRoYxFnamI9pD fycfbIhbR+J2kBENnet8a/5qhTPX8aVZG6KLcMzpVci0JWLXz3XZ6zzUzh/wcEvKMwdo fFD5U9vWIv3Tk6Q2SfrTWXibADKgaSHAEm/BAokaVRpF7UpqJTUweAmK7pmqVUo7SBii mHun/Xk5hFoxyqdVdrp6bHhxvpXjkOerFyM9xFbbGnoEHYAhDH4Vewc69BaSBi5c6sUE dUSz4Z7lYcNmWcJtALH2fP/NCPZqAH/52ktsJVVS6jPN22CAWE6Yk/7G+Qp3H4LsHOtM zzdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765805709; x=1766410509; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFO2PKd6HO5Gu1vCpikmYG9F+M/Njg31pKSD+vidcWg=; b=dOPwKqpQpkLeArBWDokOUeyyam7bwTd2xz1rmV1yfmBPzKwobobF98IMhBY6IS48vj A3tnwnvYbCTk6/wstF9XlF8F53hMHLTQH/NFETNloCsvVqsI6Witu8n3Wfa3hCHzPRFm IXHHsgpQMub0XDdFFpQ7bx4yVWceo3o7AdTIS9EL0IUec3y3mA5HFbEVelNFBON5GjK0 uou0iagESZdIqLb1G3oyADVBemdtlhptds18F1etmmUz7VwY8WWkgB/NJsE57u8ifw39 X6zXcLi9dBY6VYVe1y9QvcUVh2auWjqH3SGa4kyKc+8cGIa54m3pSi4i1Nyp23Hq1z4s MGAQ== X-Forwarded-Encrypted: i=1; AJvYcCUJe0cKi9ed1jewOkYq4BCB+pYNhx+riPaQtu2VKi/S6f6CMS9PeZ8eBcJBRhDBqH2XGWpPn/I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy96wfi9WCoDP8O4VznON1YRp6ZEq/hlS2AIBjZxEgpii3mOrwt D7HjZYkfYjd72GuWFFpwvfScLz6ETF+vUX2KhSF4yP4C1xApFPFMZIJGSgfynPAbwlQ= X-Gm-Gg: AY/fxX5TLJnfJuYEG+763YMCa0abccQteUxiWvp+iiHGt1oxiEaonpfsFRIvkJ6fQuy s+QZHaU/dq16amp+nI7GcEdcajv5PMqDje7W6def4pXYNdUkAoGR2nuqtGq5toU7DiKCBkjpHwg tQv3sxIkhv3710n4ENrHnZ9C5SJ/Q/tE4FlIMIb0JR76KZDrxiAxcEX0oBHkvQ/GaNJSCONNp5K kD2sMLvRQSCP/NTnJAp32mVUqdWStsYVvRx5x83LOU8GokLmHLmhCeQ6Z6WToVwTDGr9COIIjBR dpLn0ke/OriNF4PtTkC8gTlUD9VksneOPPdGS+rHMbJxunYW1viKq2TK4P28luIx73UY4oNzm+S 8LmUibwT/GM19asSOXk8loLu4XPyePRuKTCx7t9HF9WgEqdkgG5UPIbkzAZMU6HOZYC4JO5ELv7 3Uo7rTf5OmZ7ayInK00cofQ5dJgmo= X-Google-Smtp-Source: AGHT+IHiQpBIlY124mGCTuTCSPeK4NceHtDQc4sBvanto1eZnFu9dQVZM2lth0Wocow9MrVSOo4wLg== X-Received: by 2002:a05:600c:1d2a:b0:477:9a28:b09a with SMTP id 5b1f17b1804b1-47a8f7039c3mr116214525e9.0.1765805708725; Mon, 15 Dec 2025 05:35:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f8e9115sm189691715e9.12.2025.12.15.05.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 05:35:08 -0800 (PST) Date: Mon, 15 Dec 2025 16:35:03 +0300 From: Dan Carpenter To: Harshit Mogalapalli Cc: error27@gmail.com, smatch@vger.kernel.org Subject: Re: [PATCH] smatch_scripts: Fix incomplete quoting in kchecker make command Message-ID: References: <20251215130518.3157403-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215130518.3157403-1-harshit.m.mogalapalli@oracle.com> On Mon, Dec 15, 2025 at 05:05:18AM -0800, Harshit Mogalapalli wrote: > The previous commit added quotes around some variables and that > caused empty string arguments when variables are unset. Use > conditional expansion to only quote when variables are set. > > I see something like this > > $ kchecker --spammy net/ethtool/ioctl.c > make: *** empty string invalid as file name. Stop. > > Fixes: 9b3323efbe7f ("kchecker: Add quotes around variables") > Signed-off-by: Harshit Mogalapalli > --- > I have tested it on mine with no variables set, worth testing it when > some of these varaibles are set as well. Thanks! Applied. regards, dan carpenter