From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26D5122370A for ; Wed, 8 Apr 2026 06:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775630841; cv=none; b=coP1L44/1hpJLo/1yH/2bhHiVavfwmH/EHB/Myz9ryx+PhtyunNXZoWadvWmlUKqZp+FUaZKrX6JVLKaPrS67FB4Ka+SYNDL/uncf8yoSSPITOHHrsk8MYM0CBaq5wwTRnA/T+oWvIkqb3o5ydFpY/pTNclvNDxHNe/3V4gRR1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775630841; c=relaxed/simple; bh=8wqCv0FKgaQ1zIGMNgTj4qma7BzKJ1ImL7mDQUlTT8Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HHeKiIRRzDAfVl2MkOtoOS0WSKfDWT8t4yIBEa5Gd7P8JNVH+HkHK5iyeqZk1CgU+8oK7sfKieQSysu/r+HN/MxkTlaRBEu7HPAnNJuxmDqFoGc1R8oOA3nl5Fuz6PabcA6gR9nLKEPvykKlHo9IS9RXCLs/UcXqJy8na6a628s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mcqSWHCv; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mcqSWHCv" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488a041eae5so30021695e9.1 for ; Tue, 07 Apr 2026 23:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775630838; x=1776235638; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cx59XQCqVjVsOgcrEIpw5CotF7YVgRhxV9frqt1sk0Q=; b=mcqSWHCv1LGvAEhE1Csu8lRywd2tCy8fbjuQGjSc2aibB+2cILi2AD1Ma2p7qi8rBx Iedpp2OoC8mIRNOfpEybIp7JxuE1/TUk3umVpaFnjg1Ktvho2vRMtWy5fr0itHuHWsBL /ayBDFDYic/CFxytB3JkN4tjV4t6E4Adj91U+goAFTZAMWgjxRS6L+b6IRicqs3iG5dj A9iRuImbHV0JMasfnROAI74Ptqo3K/hoLTYtId+r69DSaY7U5kkt+sbelIzitAPAR1Bp pg8ss/AnTHTS1ge4ZbErOUq9PLaNeBdOE5CBcitOTrKL1Fh0ibm5wSG/YS+gdrBVrY1Y OYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775630838; x=1776235638; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cx59XQCqVjVsOgcrEIpw5CotF7YVgRhxV9frqt1sk0Q=; b=mrIkuoWTShWpDqJspbTuS2ApGkzWvN2bMhBZU86F1L9safLCe3QH+fJ396QPbbCA5Y Et13gegyx32hVygsaVoDgOFtFR5yd4LpSbFqYuWtxF2Goq7eAgaguecwK1yh+eaOK2Q5 q+PEBPQ7bbvkAXQqMCrV5R1Aejvnumm55HD2+DufHrcrTKKR9k5bOX++PWpsP5fmLdpM USW0mF7UGXER2OyM8vlT0ToF6X+DzzOyZnQ9durbo5zTleaGki+UsXwBhwNxl82ZFavg Tj9wudSXo7VpnWfzcn4fPuFLp65yT0Pyo1koMNd3uuRTbpG59O5gJqn1Zf6ue9Nb4GQF /2kA== X-Gm-Message-State: AOJu0Yw5Zk9OtrUXRqp80uev819N+Q5h77N+Jbwq4ps9SKt/dhfAZuTx 7/M8CyOJiYz2uzfQHjNVo7KuDg4Yqz5gE5KwALyT7XV7oUEX6bHm3Ufb8tsTxg== X-Gm-Gg: AeBDiet3YechxzLdUCPN0RiXGKmJN4R9XMmH4TV69R+B22ZUHM+6FtGFvs/EjG0Ir4k trT8pcw1b7Dw2AGAXFFwTkAVn116SnZSr6ARALUiplG+BWu12UiulXrtmLhbJZa4Q+4FL9olAIH lPxDdJI5cfVOE8ht/PaYaDw097VV5vdOmQTAtYjHxlEXzGgI1s48y26exrGbUhcbsCV6Q/HBJtc l57gEKtfSzfDuieETLrv7FqQCK8t3Y8ZZ2o+lJertRnYV1PFoSfb1gK9qEm9zjNlZpTX5wr8TA7 f+1o6ldcTqqhvrFy0tjblLLe+lklASn8YWtiy16XwNqHx1wBV68djazrwyQqKT+wSGwnXToJ9/i 3O8aGd59Tx9ooXajkocgxfSMpcEmE55pRfqR9ybcGB5EX3EycwTovVBpAAm7eHQRyQJGwDuddDE 3nosrWjuV5Ty7tRKqpkhs= X-Received: by 2002:a05:600c:1c21:b0:488:b87b:3052 with SMTP id 5b1f17b1804b1-488b87b3508mr109051525e9.29.1775630838265; Tue, 07 Apr 2026 23:47:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a91686f9sm346431175e9.10.2026.04.07.23.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 23:47:17 -0700 (PDT) Date: Wed, 8 Apr 2026 09:47:14 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: smatch@vger.kernel.org Subject: Re: [SMATCH] Can also be NULL false positive Message-ID: References: Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 07, 2026 at 11:16:45AM -0500, Ethan Tidmore wrote: > Hi Dan, > > Smatch gives these two warnings: > > drivers/gpu/drm/i915/display/intel_crtc.c:333 __intel_crtc_init() warn: 'primary' can also be NULL > drivers/gpu/drm/i915/display/intel_crtc.c:348 __intel_crtc_init() warn: 'plane' can also be NULL > > if (DISPLAY_VER(display) >= 9) > primary = skl_universal_plane_create(display, pipe, PLANE_1); > else > primary = intel_primary_plane_create(display, pipe); > if (IS_ERR(primary)) { > ret = PTR_ERR(primary); > goto fail; > } > crtc->plane_ids_mask |= BIT(primary->id); > > and > > if (DISPLAY_VER(display) >= 9) > plane = skl_universal_plane_create(display, pipe, PLANE_2 + sprite); > else > plane = intel_sprite_plane_create(display, pipe, sprite); > if (IS_ERR(plane)) { > ret = PTR_ERR(plane); > goto fail; > } > crtc->plane_ids_mask |= BIT(plane->id); > > But, this is a false positive because skl_universal_plane_create() and > intel_sprite_plane_create() never return NULL and always error pointers. I don't see that warning on my builds. One thing that I see is that intel_primary_plane_create() can return NULL if CONFIG_I915 is disabled. But I can't see how we would build that file without CONFIG_I915. I wondered if it might be a CONFIG_COMPILE_TEST thing, but I don't see that possibility. Do you have the cross function DB built? regards, dan carpenter