From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD36190462 for ; Mon, 17 Aug 2026 08:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786955202; cv=none; b=X5XVbI3fUelEfY/Ei9o6gFJor11CH7kM88DHN8IGCTB/gW+gQn8OGKugaHkmCvzZOiPL0IbOkh3EhkCR/de/FBXxhLjqrFeqCT7xBm7I8OeZM07xyBzNEahUVPAL6ZHHzpH94aKUVTwvb9T37adlxbHRVHWXHCzH1y0p2ZrCX0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786955202; c=relaxed/simple; bh=pSc/lpoj2mxTroNluh6XwZvsvsH1YKlmcIYFolxiu2E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZFZZ/5iWqkAkLvjWLMOQK6L2JL5XQLBd1656D1GpoukGksCsuS0vjabzgi5a5UKVY8dhi8DUqHOuJd1qp8AWY3CahbHC1diyECJ0ij2IUds5yD3g9r/jW6HCUewh90+1190U6Y9KRf1H6zN8QftXASrMYjfxqtljQV0gps/HqYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dB44QBHx; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dB44QBHx" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f633e6058so2736986f8f.0 for ; Mon, 17 Aug 2026 01:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786955199; x=1787559999; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aYlOofK7Xsmw2DWcz7oAdGuaOvkMHLz5BCeoGM1vvJU=; b=dB44QBHxp6eRgFZKo2/WWXAs6y6ZPMUcPr9nTX5K/AssbgvryJiBTlS/aQuD1Z8hAL xZBnkh5EaYNq9vk+TbtW1OEzOxEtMbkfJP67n6ZLK9uD0/s3TjkJXi5l9WlL/KWKSoI6 agmhmeVB+b2wMbAK6Pl9i4Qm0ZZbnkJLTYKVLDAm6ywRnQFwYxbYVB2gOk2qnLFFmbuI +Ebii2RR4wVbGCIivz4M3GyjoAxNonkzJNOfYxrsgJVkVpb6/i7f0KNtxDnn/ufgE2J5 Ewiu2dmWEQHwVpqj5tGXquF8uJPKxrX8KVhONWcTK6EmfDxGgHs5cDrZIfu+gF9UotZl 8/vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786955199; x=1787559999; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aYlOofK7Xsmw2DWcz7oAdGuaOvkMHLz5BCeoGM1vvJU=; b=GttU24mAmgaL16Lhpd3fUtptG7ZiwrKi1FyiTmgo+hM501OjAtqGiCorYWwmHkZPt9 EceJaYwHry4FI7expTZGr7hvDSKOKck8XHT35l5vDre6hHzsvxue/jS+WzNGq4mx7h7l 3sGUODFTDDR2lIYxDP8e3o7AlVgCLIobBA2ayd9m5ekrg7GS1zXxKfcR/xELOHkAtF03 /L2HYPy8RKB5KFRI6861jQW4wYtq+ZJIfdEqJaJFCzk3LDSwtAeCeO0wL9BjwbmmGNsd vGvhpazp0Z9z9aJOmtiMRlxiwXHXbkAIANKminSW4N4Y47/bIuRZQp82PUA77AkPpWKN ir2g== X-Gm-Message-State: AOJu0YyYCGeCUPZ4Bc78NRpQv/fBPsz6fKRk+J5iCNewmL+qixi2MNhv OIq8KHl4q8bv1x0hlYMKypprhRfMJP0ZjIL+T0l6jczuRgnO/VrSY65h3mTJ6Lrq61a+yAJf X-Gm-Gg: AR+sD10kAV52pUdOlRtsDncyvYSXDgcRpHyx9k7CfY2ssQOpgh70wqfUQzl+trvaKLM ko9j74S69h9dISC8f0hXYzgcynMRLccmZNHr+/Xv5xPWPqYM5al9lo8Q+SbBvjso+gnjZgMuN8n zKdjK0BvLdyIFp31j7ER7EzNdY+c1LAHW0mhanZm9JhogBtgxpPxfZiNCchpPBKU9gXFZfSgn1b 9dkm2b8oljgukzRjkygA2zlVLvdwq2E8VsLRqLExZFnzd87pOlSVx3rCigZNN53PQYxgJl8FvH6 bexeGuvdGCfE7/wCID8Tcrrsu9MM1I5Uyrgj3K9814BukHZdio5ixwEElMEmWQWzZ3Hn8AFXqN1 rPsaZ3yTFJ7fm2jt7qNkJIFqPpE4LEM15JO3iPJFWddpUGMwkowdFEZJQpph4BL4UiC6t6AnLN8 kZUPw1BC1KPSBsP3K/H10kPvAXWiKV2/L9OoxrLGfK1G7qvXqFivMHXZKwBA== X-Received: by 2002:a05:6000:26c4:b0:47f:9283:1fb3 with SMTP id ffacd0b85a97d-481606d2962mr35490245f8f.0.1786955198681; Mon, 17 Aug 2026 01:26:38 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:9cf4:43df:e612:817b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm2253883f8f.9.2026.08.17.01.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 01:26:37 -0700 (PDT) Date: Mon, 17 Aug 2026 11:26:33 +0300 From: Dan Carpenter To: Arka Mondal Cc: smatch@vger.kernel.org Subject: Re: [PATCH 0/4] fix build warnings on gcc-16 and glibc-2.43 Message-ID: References: <20260814070954.944614-1-arkamondalofficial@gmail.com> Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260814070954.944614-1-arkamondalofficial@gmail.com> Thanks, I applied this to the devel branch of Smatch. https://github.com/error27/smatch/tree/devel On Fri, Aug 14, 2026 at 04:09:50PM +0900, Arka Mondal wrote: > Smatch builds with 14 warnings on gcc-16 and glibc-2.43. This fixes 12. > Only the last patch changes behavior: it returns instead of storing a > truncated name. > > Six of these are new. glibc-2.43 returns const from strchr() and strstr() > on const strings, and gcc-15 defaults to -std=gnu23 which enables it. > > Two are left. assume_indexes_are_valid() is unused because its add_hook() > call is commented out. > > The other is in smatch_kernel_user_data.c: > > if (param_data_treat_untagged(value) || sym->ctype.as == 5) > > ctype.as is a struct ident pointer, so this is never true. It has never > worked: ctype.as became an ident in 69fce9f7 (Dec 2018), this code in 5f2fcd8a (Oct > 2019). Revive the check or delete the condition? I didn't write that code and I did ask about it but I'm not sure what was intended really... I've deleted it, since it hopefully can't possibly be true... I'll push that later. (I worry that there is an reason for that weird condition. Perhaps it was a hack around for memory corruption or something. :P But surely all those ancient bugs have been replaced with new bugs by now). regards, dan carpenter