From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E9A4C9DFA for ; Thu, 15 Oct 2026 11:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792064304; cv=none; b=dONw5KSJfuz3WBRSeBM2Wu0nRh+Ihki64+Bw4ZDN8OtKgPFdLKyIKRqi5iaX4/gl5/zGBWZffe/cocUAeKx+6b893BLTY+KFVPc9u/MXnviDnhK/1KAhZV7LrqddCGN4Q/6wOYXqwC0ztupSKFHRS4mK3KbCDnlcGBKH6ZrF3tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792064304; c=relaxed/simple; bh=mnfSdId9WLDP/UL6izoytd1maLN5c2vnxKy6StmGmwg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lT/3nusQuIsCkTKO74kkJAJNpDB3tyYzeCBRMG/RViQXyqmyZMzuc+OWtoS6fjQOdhCxL0pqKF34+gSewlNjSCeqf2bCogKtudoc5xifZCjIZWF5661NijcLwUu8qWlDzhPWcHG17mfarWsAsmNQYRaFuPhJgzObDH5HRmYSx6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z8KRpTps; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8KRpTps" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a018dc1f98so41701835e9.3 for ; Thu, 15 Oct 2026 04:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792064296; x=1792669096; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jDHnCV0mizEdvB+S2S7Pg7FHyU72BhWnZ07AQ/1QhyI=; b=Z8KRpTpseCL85MPoMp2CI9Pe87lNnv+1i4SQRRT3lAK/7yINceHtDNz5oO2/XSu4Df gqzXuCzDnLez7J0N+2OsdGSpgce3jR/ZSF5gUjuvFIykcI5KTMtYC9W7uq+O5gYl63fa tSfFMsoOxbPUNjYjudKoItVXt634QqoCuW/0tiGRC/C/obQI4CIpqbMDgMVaNszcPIls 91c0dOQ3dpQY0n6f+4f7L/rhHUJQIjvWPKjxjpIG9VkXH5h1z6t9sz7Hq11fQVha4mn4 D62LRE5wRSJN6+Vh2zXLs66nTDHLlU6VCrQwNiQaD+iUQwJSc1fYaR0iYq2gpsYxGPjL +5Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792064296; x=1792669096; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jDHnCV0mizEdvB+S2S7Pg7FHyU72BhWnZ07AQ/1QhyI=; b=t16Mf/voSxa4ijk/r6hyquLBlgMpRUQHZ78eYFXu0gMZTPvP6Vi0AlkxDraLK6Lqe8 xWf9qY4J2jNP3PWbShCyFTJC+xETArHN4f6biz30eSk4lNnf5EZqpRMyTMDs97ocQWHk IxtxnI1sSuV4O5iBZnmtto9kTj/FJ1jBsTpl8YUsZ0KWp7iP9DBKDM+lmPvZKFHZJVxw G0b6RZExQCEiLQ2kv5aeYKM97dQaqaT/J4voprmZjIWAkh8lndp+q/QhG00gVn+vGuc9 JtBoEk12qx1QtGXk0MIRGBjN4V5xDC/meg0MKXZSoMCKeIH88d9cQ3HGzvGd4BJa4DzQ VLCg== X-Gm-Message-State: AFq9FYIbFszC8zmAAUB5tEKDyjY5TXO+sLL269T/aPzs/EK9rkjojW/d 1/uvH0qZbPHGVtW8c1oy+Dx/d5rT2wHD3irfevhlzRLaEE5o0e+MdfvM X-Gm-Gg: AYBFou2ht3XLWpnTUBMLUz8qmlcnv0pRiGYYmUiLyKAmftjcdqnQTiUHv0PDLktcXoZ Xy8BjnuZhYbDVbJN7VgwRkzRG0FS9EzlkmnRt9G0Tbd15lbJMMpEXvhgjlehqCg/ix6EZlpsU6m tsswmgiutIFX/mMUyWfsB3aWNrZPUaZ/sl5ruNRboLoWcBiykgoP+JsaVhwGap+dfDpenO0bjE4 ohZZjzsfhzrM5D80m0LBH41V1JiHtfdxR0vtxVVJFXT7t8dRSnY8xSIRumQVXl82uq6wyz6FKKo JqIDacgAURR6Uh/oFfZJVzd20wRWAO6p4HRwjXosHPn2ptmgiFEGYGVGvCQEA1B9vltsXsOCC9b xBd2GwK8CHswoD+qQF9hCFoaJrFC2WvyImO9jdfHAMbV0uccpt9nKZ9sBEY9cizbezeRVBDyAAc tsztMZ0QJNFymIt9lfGotwguiF2DO8IVd+R5ceUfXdxzgLtdWc0KZLWnAw/uiuxhJKEFWi2KNGn tJt4A== X-Received: by 2002:a05:600c:5247:b0:4a1:6991:36d7 with SMTP id 5b1f17b1804b1-4a18e49d570mr365960915e9.10.1792064295779; Thu, 15 Oct 2026 04:38:15 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1bd5eb046sm46234175e9.0.2026.10.15.04.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 04:38:15 -0700 (PDT) Date: Thu, 15 Oct 2026 14:38:11 +0300 From: Dan Carpenter To: Thomas Fourier Cc: smatch@vger.kernel.org Subject: Re: [PATCH smatch] Add safety checks in various modules Message-ID: References: <20261006132038.42445-3-fourier.thomas@gmail.com> Precedence: bulk X-Mailing-List: smatch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006132038.42445-3-fourier.thomas@gmail.com> On Tue, Oct 06, 2026 at 03:20:40PM +0200, Thomas Fourier wrote: > diff --git a/smatch_math.c b/smatch_math.c > index ecb911a2..f5e88bdd 100644 > --- a/smatch_math.c > +++ b/smatch_math.c > @@ -69,6 +69,8 @@ static bool last_stmt_rl(struct statement *stmt, int implied, int *recurse_cnt, > return false; > > stmt = last_ptr_list((struct ptr_list *)stmt->stmts); > + if (!stmt) > + return false; > if (stmt->type == STMT_LABEL) { > if (stmt->label_statement && > stmt->label_statement->type == STMT_EXPRESSION) > @@ -1979,6 +1981,9 @@ int get_value(struct expression *expr, sval_t *res_sval) > sval_t sval = {}; > int i; > > + if (!expr || expr->type >= NUM_EXPRESSION) This could only happen if there is memory corruption so it's really just a bandaid fix. Anyway, applied. Thanks! regards, dan carpenter