From: John Garry <john.garry@huawei.com>
To: <xuwei5@hisilicon.com>
Cc: <andriy.shevchenko@linux.intel.com>, <linuxarm@huawei.com>,
<rafael.j.wysocki@intel.com>, <linux-kernel@vger.kernel.org>,
<soc@kernel.org>, <yangyingliang@huawei.com>,
John Garry <john.garry@huawei.com>
Subject: [PATCH v3 2/5] bus: hisi_lpc: Use devm_platform_ioremap_resource
Date: Mon, 5 Sep 2022 16:23:03 +0800 [thread overview]
Message-ID: <1662366186-233933-3-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1662366186-233933-1-git-send-email-john.garry@huawei.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
The struct resource is not used for anything else, so we can simplify
the code a bit by using the helper function.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/bus/hisi_lpc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
index 6d432a07cbba..03d4d96ff794 100644
--- a/drivers/bus/hisi_lpc.c
+++ b/drivers/bus/hisi_lpc.c
@@ -618,7 +618,6 @@ static int hisi_lpc_probe(struct platform_device *pdev)
struct logic_pio_hwaddr *range;
struct hisi_lpc_dev *lpcdev;
resource_size_t io_end;
- struct resource *res;
int ret;
lpcdev = devm_kzalloc(dev, sizeof(*lpcdev), GFP_KERNEL);
@@ -627,8 +626,7 @@ static int hisi_lpc_probe(struct platform_device *pdev)
spin_lock_init(&lpcdev->cycle_lock);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- lpcdev->membase = devm_ioremap_resource(dev, res);
+ lpcdev->membase = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(lpcdev->membase))
return PTR_ERR(lpcdev->membase);
--
2.35.3
next prev parent reply other threads:[~2022-09-05 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 8:23 [PATCH v3 0/5] Misc hisi_lpc changes John Garry
2022-09-05 8:23 ` [PATCH v3 1/5] bus: hisi_lpc: Don't dereference fwnode handle John Garry
2022-09-05 8:23 ` John Garry [this message]
2022-09-05 8:23 ` [PATCH v3 3/5] bus: hisi_lpc: Correct error code for timeout John Garry
2022-09-05 8:23 ` [PATCH v3 4/5] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR() John Garry
2022-09-05 8:23 ` [PATCH v3 5/5] bus: hisi_lpc: Use platform_device_register_full() John Garry
2022-09-13 1:47 ` [PATCH v3 0/5] Misc hisi_lpc changes Wei Xu
2022-09-23 16:20 ` patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662366186-233933-3-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=soc@kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox