public inbox for soc@kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1
@ 2025-11-27 10:00 Chen-Yu Tsai
  2025-11-27 13:25 ` AngeloGioacchino Del Regno
  2025-11-27 22:10 ` patchwork-bot+linux-soc
  0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2025-11-27 10:00 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: Chen-Yu Tsai, linux-mediatek, linux-arm-kernel, devicetree, soc

The base address of JPEG decoder core 1 should start at 0x10000, and
have a size of 0x10000, i.e. it is right after core 0.

Instead the core has  the same base address as core 0, and with a crazy
large size. This looks like a mixup of address and size cells when the
ranges were converted.

This causes the kernel to fail to register the second core due to sysfs
name conflicts:

    sysfs: cannot create duplicate filename '/devices/platform/soc/soc:jpeg-decoder@1a040000/1a040000.jpgdec'

Fix up the address range.

Fixes: a9eac43d039f ("arm64: dts: mediatek: mt8195: Fix ranges for jpeg enc/decoder nodes")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
This was introduced in v6.18-rc1.

Maybe have the soc maintainers take this directly instead of waiting?

Also, I'm not sure if this error could mess up the JPEG decoder driver's
internal tracking.

 arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ec452d657031..c7adafaa8328 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3067,7 +3067,7 @@ jpgdec@0,0 {
 
 			jpgdec@0,10000 {
 				compatible = "mediatek,mt8195-jpgdec-hw";
-				reg = <0 0 0x10000 0x10000>;/* JPGDEC_C1 */
+				reg = <0 0x10000 0 0x10000>;/* JPGDEC_C1 */
 				iommus = <&iommu_vdo M4U_PORT_L19_JPGDEC_WDMA0>,
 					 <&iommu_vdo M4U_PORT_L19_JPGDEC_BSDMA0>,
 					 <&iommu_vdo M4U_PORT_L19_JPGDEC_WDMA1>,
-- 
2.52.0.487.g5c8c507ade-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1
  2025-11-27 10:00 [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1 Chen-Yu Tsai
@ 2025-11-27 13:25 ` AngeloGioacchino Del Regno
  2025-11-27 22:10 ` patchwork-bot+linux-soc
  1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-11-27 13:25 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger, Arnd Bergmann
  Cc: linux-mediatek, linux-arm-kernel, devicetree, soc

Il 27/11/25 11:00, Chen-Yu Tsai ha scritto:
> The base address of JPEG decoder core 1 should start at 0x10000, and
> have a size of 0x10000, i.e. it is right after core 0.
> 
> Instead the core has  the same base address as core 0, and with a crazy
> large size. This looks like a mixup of address and size cells when the
> ranges were converted.
> 
> This causes the kernel to fail to register the second core due to sysfs
> name conflicts:
> 
>      sysfs: cannot create duplicate filename '/devices/platform/soc/soc:jpeg-decoder@1a040000/1a040000.jpgdec'
> 
> Fix up the address range.
> 
> Fixes: a9eac43d039f ("arm64: dts: mediatek: mt8195: Fix ranges for jpeg enc/decoder nodes")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
> This was introduced in v6.18-rc1.
> 
> Maybe have the soc maintainers take this directly instead of waiting?

I'm fine with that; if Arnd wants to take it directly, that'd be easier for me as
I really don't expect any other Fixes commits for the moment (and I'm currently in
a very, very... very busy "moment").

Cheers,
Angelo

> 
> Also, I'm not sure if this error could mess up the JPEG decoder driver's
> internal tracking.
> 
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ec452d657031..c7adafaa8328 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -3067,7 +3067,7 @@ jpgdec@0,0 {
>   
>   			jpgdec@0,10000 {
>   				compatible = "mediatek,mt8195-jpgdec-hw";
> -				reg = <0 0 0x10000 0x10000>;/* JPGDEC_C1 */
> +				reg = <0 0x10000 0 0x10000>;/* JPGDEC_C1 */
>   				iommus = <&iommu_vdo M4U_PORT_L19_JPGDEC_WDMA0>,
>   					 <&iommu_vdo M4U_PORT_L19_JPGDEC_BSDMA0>,
>   					 <&iommu_vdo M4U_PORT_L19_JPGDEC_WDMA1>,


-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1
  2025-11-27 10:00 [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1 Chen-Yu Tsai
  2025-11-27 13:25 ` AngeloGioacchino Del Regno
@ 2025-11-27 22:10 ` patchwork-bot+linux-soc
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-soc @ 2025-11-27 22:10 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Thu, 27 Nov 2025 18:00:42 +0800 you wrote:
> The base address of JPEG decoder core 1 should start at 0x10000, and
> have a size of 0x10000, i.e. it is right after core 0.
> 
> Instead the core has  the same base address as core 0, and with a crazy
> large size. This looks like a mixup of address and size cells when the
> ranges were converted.
> 
> [...]

Here is the summary with links:
  - arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1
    https://git.kernel.org/soc/soc/c/ce48af13e638

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-27 22:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-27 10:00 [PATCH] arm64: dts: mediatek: mt8195: Fix address range for JPEG decoder core 1 Chen-Yu Tsai
2025-11-27 13:25 ` AngeloGioacchino Del Regno
2025-11-27 22:10 ` patchwork-bot+linux-soc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox