From: "Pali Rohár" <pali@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>
Cc: soc@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND 8/8] leds: turris-omnia: change max brightness from 255 to 1
Date: Mon, 26 Dec 2022 13:36:30 +0100 [thread overview]
Message-ID: <20221226123630.6515-9-pali@kernel.org> (raw)
In-Reply-To: <20221226123630.6515-1-pali@kernel.org>
From: Marek Behún <kabel@kernel.org>
Using binary brightness makes more sense for this controller, because
internally in the MCU it works that way: the LED has a color, and a
state whether it is ON or OFF.
The resulting brightness computation with led_mc_calc_color_components()
will now always result in either (0, 0, 0) or the multi_intensity value.
Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: 089381b27abe ("leds: initial support for Turris Omnia LEDs")
Reviewed-by: Pali Rohár <pali@kernel.org>
---
drivers/leds/leds-turris-omnia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index 71340dec492a..04f01ae46c27 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -146,7 +146,7 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led,
init_data.fwnode = &np->fwnode;
cdev = &led->mc_cdev.led_cdev;
- cdev->max_brightness = 255;
+ cdev->max_brightness = 1;
cdev->brightness_set_blocking = omnia_led_brightness_set_blocking;
cdev->trigger_type = &omnia_hw_trigger_type;
cdev->default_trigger = omnia_hw_trigger.name;
--
2.20.1
next prev parent reply other threads:[~2022-12-26 12:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 12:36 [PATCH RESEND 0/8] Resend LED patches Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 1/8] dt-bindings: leds: register-bit-led: Add active-low property Pali Rohár
2023-01-27 11:16 ` Lee Jones
2023-02-23 14:22 ` Lee Jones
2023-02-23 16:48 ` Pali Rohár
2023-02-23 20:59 ` Linus Walleij
2023-02-24 8:42 ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 2/8] leds: syscon: Implement support for " Pali Rohár
2023-02-23 14:25 ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 3/8] powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board CPL Design Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 4/8] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Pali Rohár
2023-01-27 11:16 ` Lee Jones
2023-02-24 9:15 ` Krzysztof Kozlowski
2023-02-24 9:38 ` Lee Jones
2023-03-09 20:42 ` Pali Rohár
2023-03-11 11:47 ` Krzysztof Kozlowski
2023-02-24 9:13 ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 5/8] leds: Add support for Turris 1.x LEDs Pali Rohár
2023-01-27 11:20 ` Lee Jones
2023-02-02 23:46 ` Pali Rohár
2023-02-24 9:25 ` Krzysztof Kozlowski
2023-02-24 9:37 ` Lee Jones
2023-02-24 9:22 ` Krzysztof Kozlowski
2023-02-24 9:28 ` Lee Jones
2023-03-09 20:35 ` Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 6/8] leds: turris-omnia: support HW controlled mode via private trigger Pali Rohár
2023-02-24 9:32 ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 7/8] leds: turris-omnia: initialize multi-intensity to full Pali Rohár
2023-02-24 9:33 ` Lee Jones
2022-12-26 12:36 ` Pali Rohár [this message]
2023-02-24 9:34 ` [PATCH RESEND 8/8] leds: turris-omnia: change max brightness from 255 to 1 Lee Jones
2023-03-09 20:07 ` Pali Rohár
2023-01-20 16:41 ` [PATCH RESEND 0/8] Resend LED patches Arnd Bergmann
2023-01-20 17:15 ` Lee Jones
2023-01-20 17:47 ` Arnd Bergmann
2023-01-20 20:02 ` Lee Jones
2023-01-26 20:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221226123630.6515-9-pali@kernel.org \
--to=pali@kernel.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).