Re: [PATCH v5 01/11] dt-bindings: arm: add cznic,turris-omnia-mcu binding

Krzysztof Kozlowski
2024-03-26T08:45:06Z

On 23/03/2024 17:43, Marek Behún wrote:
> Add binding for cznic,turris-omnia-mcu, the device-tree node
> representing the system-controller features provided by the MCU on the
> Turris Omnia router.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes from v4:
> - #gpio-cells changed from 2 (pin number, flags) to 3 (bank, pin number,
> flags). This is because two years ago we added device-tree fixing code
> into U-Boot [1] which adds reset-gpios to PCIe controller nodes if
> these GPIOs are controllable via MCU, and the code adds the gpio
> specifiers to have 3 cells. Implementing this driver with twocell
> specifier breaks PCIe functionality for users which have upgraded U-Boot
> - added documentation for #interrupt-cells and #gpio-cells
>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof