Re: [PATCH v2 11/17] firmware: turris-mox-rwtm: Use dev_err_probe() where possible

["Marek Behún" <kabel@kernel.org>]

On Thu, 13 Jun 2024 22:49:18 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Jun 13, 2024 at 6:11 PM Marek Behún <kabel@kernel.org> wrote:
> >
> > Use dev_err_probe() where possible in the driver's .probe() method.  
> 
> ...
> 
> >         rwtm->mbox = mbox_request_channel(&rwtm->mbox_client, 0);
> >         if (IS_ERR(rwtm->mbox)) {
> >                 ret = PTR_ERR(rwtm->mbox);
> > -               if (ret != -EPROBE_DEFER)
> > -                       dev_err(dev, "Cannot request mailbox channel: %i\n",
> > -                               ret);
> > -               return ret;  
> 
> > +               if (ret == -EPROBE_DEFER)
> > +                       return ret;  
> 
> What;s the point of this check, please?
> 
> > +               return dev_err_probe(dev, ret,
> > +                                    "Cannot request mailbox channel!\n");
> >         }  
> 
> 

The point is to not print the error message if we just need to wait for
the mailbox driver.