From: "Marek Behún" <kabel@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: "Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, "Gregory CLEMENT" <gregory.clement@bootlin.com>,
arm@kernel.org, "Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Marek Behún" <kabel@kernel.org>
Subject: [PATCH leds v2 10/11] leds: turris-omnia: Use 100 columns in the rest of the code
Date: Tue, 3 Sep 2024 12:19:29 +0200 [thread overview]
Message-ID: <20240903101930.16251-11-kabel@kernel.org> (raw)
In-Reply-To: <20240903101930.16251-1-kabel@kernel.org>
There are 7 more places in the code where the 100 column limit can be
used to make the code more uniform. Do it.
Signed-off-by: Marek Behún <kabel@kernel.org>
---
drivers/leds/leds-turris-omnia.c | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index 58c3f3afbca5..4ab76b5b5e68 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -44,8 +44,7 @@ static int omnia_cmd_set_color(const struct i2c_client *client, u8 led, u8 r, u8
return omnia_cmd_write(client, buf, sizeof(buf));
}
-static int omnia_led_send_color_cmd(const struct i2c_client *client,
- struct omnia_led *led)
+static int omnia_led_send_color_cmd(const struct i2c_client *client, struct omnia_led *led)
{
int ret;
@@ -90,8 +89,7 @@ static int omnia_led_brightness_set_blocking(struct led_classdev *cdev,
* implement the division instruction).
*/
if (brightness || led->hwtrig) {
- led_mc_calc_color_components(mc_cdev, brightness ?:
- cdev->max_brightness);
+ led_mc_calc_color_components(mc_cdev, brightness ?: cdev->max_brightness);
/*
* Send color command only if brightness is non-zero and the RGB
@@ -174,8 +172,7 @@ static void omnia_hwtrig_deactivate(struct led_classdev *cdev)
mutex_unlock(&leds->lock);
if (err)
- dev_err(cdev->dev, "Cannot put LED to software mode: %i\n",
- err);
+ dev_err(cdev->dev, "Cannot put LED to software mode: %i\n", err);
}
static struct led_trigger omnia_hw_trigger = {
@@ -251,8 +248,7 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led,
if (ret < 0)
return dev_err_probe(dev, ret, "Cannot set LED %pOF initial color\n", np);
- ret = devm_led_classdev_multicolor_register_ext(dev, &led->mc_cdev,
- &init_data);
+ ret = devm_led_classdev_multicolor_register_ext(dev, &led->mc_cdev, &init_data);
if (ret < 0)
return dev_err_probe(dev, ret, "Cannot register LED %pOF\n", np);
@@ -270,8 +266,7 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led,
* file lives in the device directory of the LED controller, not an individual
* LED, so it should not confuse users.
*/
-static ssize_t brightness_show(struct device *dev, struct device_attribute *a,
- char *buf)
+static ssize_t brightness_show(struct device *dev, struct device_attribute *a, char *buf)
{
struct i2c_client *client = to_i2c_client(dev);
u8 reply;
@@ -303,8 +298,7 @@ static ssize_t brightness_store(struct device *dev, struct device_attribute *a,
}
static DEVICE_ATTR_RW(brightness);
-static ssize_t gamma_correction_show(struct device *dev,
- struct device_attribute *a, char *buf)
+static ssize_t gamma_correction_show(struct device *dev, struct device_attribute *a, char *buf)
{
struct i2c_client *client = to_i2c_client(dev);
struct omnia_leds *leds = i2c_get_clientdata(client);
@@ -320,8 +314,7 @@ static ssize_t gamma_correction_show(struct device *dev,
return sysfs_emit(buf, "%d\n", !!reply);
}
-static ssize_t gamma_correction_store(struct device *dev,
- struct device_attribute *a,
+static ssize_t gamma_correction_store(struct device *dev, struct device_attribute *a,
const char *buf, size_t count)
{
struct i2c_client *client = to_i2c_client(dev);
--
2.44.2
next prev parent reply other threads:[~2024-09-03 10:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 10:19 [PATCH leds v2 00/11] Turris Omnia LED driver changes Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 01/11] turris-omnia-mcu-interface.h: Move command execution function to global header Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 02/11] leds: turris-omnia: Use command execution functions from the MCU driver Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 03/11] turris-omnia-mcu-interface.h: Add LED commands related definitions to global header Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 04/11] leds: turris-omnia: Use global header for MCU command definitions Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 05/11] leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 06/11] platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 07/11] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 08/11] leds: turris-omnia: Use dev_err_probe() where appropriate Marek Behún
2024-09-03 10:45 ` Andy Shevchenko
2024-09-03 15:56 ` Andrew Lunn
2024-09-03 16:28 ` Andy Shevchenko
2024-09-04 7:37 ` Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 09/11] leds: turris-omnia: Use uppercase first letter in all comments Marek Behún
2024-09-03 10:19 ` Marek Behún [this message]
2024-09-03 13:21 ` [PATCH leds v2 10/11] leds: turris-omnia: Use 100 columns in the rest of the code Arnd Bergmann
2024-09-04 7:28 ` Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 11/11] ARM: dts: turris-omnia: Add global LED brightness change interrupt Marek Behún
2024-09-03 14:26 ` [PATCH leds v2 00/11] Turris Omnia LED driver changes Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903101930.16251-11-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox