From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AFEEC3DA79 for ; Mon, 15 Jan 2024 08:41:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 58642C433A6; Mon, 15 Jan 2024 08:41:36 +0000 (UTC) Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id E0685C433F1; Mon, 15 Jan 2024 08:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org E0685C433F1 Authentication-Results: smtp.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705308092; bh=C3rT1/ddNThmU1OTPQTOVjH0MXuCDiqlLPyDw+7f5lw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=yLQ0h/T9YjM33CfzM7ECMQ2MDC69fQg37HD0pvwsL/tJ3fLbfNOMP3JTJG7+eiHyG uW9YPNkH1nyOATKBxyHtj5JB+B7iiMQHTucpBL71YSwsgv6viecr9FWGN3Hm9lcI+k NSsiFXCTof3XQPjt+Zz2lDg2JzLqWx5qapNSnI+YwD+Kyv0jYcPSfhvoVqUMu6TWZ2 YoOhhRI03yEX+AntGcJsnkB8riw8n+sfGwj6B/UWDP3Vmi426el+tAAMgpyMaatRU+ qxf9f01taD7sz6szS2iqhVzzpFsfEWJKea3o9i9FU+6CeZ0D6Non2FvU58XIPOVSBN tlZpwCftk8lvg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E7D3D37813E0; Mon, 15 Jan 2024 08:41:30 +0000 (UTC) Message-ID: <682b50dc-a92a-4da5-ad06-631c5125ebc5@collabora.com> Date: Mon, 15 Jan 2024 09:41:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: Fix TPM schema violations List-Id: To: Lukas Wunner , Arnd Bergmann , Olof Johansson , soc@kernel.org, devicetree@vger.kernel.org, linux-integrity@vger.kernel.org Cc: Yannic Moog , Alexander Bauer , upstream@lists.phytec.de, Teresa Remmet , Tim Harvey , Shawn Guo , Sascha Hauer , kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, Adam Ford , Heiko Thiery , Enric Balletbo i Serra , Matthias Brugger , Hsin-Yi Wang , Chen-Yu Tsai , Nicolas Prado , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 13/01/24 19:06, Lukas Wunner ha scritto: > Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS > bindings"), several issues are reported by "make dtbs_check" for arm64 > devicetrees: > > The compatible property needs to contain the chip's name in addition to > the generic "tcg,tpm_tis-spi" and the nodename needs to be "tpm@0" > rather than "cr50@0": > > tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short > from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml# > > cr50@0: $nodename:0: 'cr50@0' does not match '^tpm(@[0-9a-f]+)?$' > from schema $id: http://devicetree.org/schemas/tpm/google,cr50.yaml# > > Fix these schema violations. > > phyGATE-Tauri uses an Infineon SLB9670: > https://lore.kernel.org/all/ab45c82485fa272f74adf560cbb58ee60cc42689.camel@phytec.de/ > > Gateworks Venice uses an Atmel ATTPM20P: > https://trac.gateworks.com/wiki/tpm > > Signed-off-by: Lukas Wunner For MediaTek: Reviewed-by: AngeloGioacchino Del Regno ...but I think you should split this per-SoC. Anyway, if Arnd wants to take this patch directly I'm also totally fine with that. Cheers, Angelo