Re: [PATCH v2 4/6] arm64: dts: axiado: Add initial support for AX3000 SoC and eval board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/06/2025 00:41, Harshit Shah wrote:
>>> +
>>> +             spi_clk: spi_clk {
>>> +                     compatible = "fixed-clock";
>>> +                     #clock-cells = <0>;
>>> +                     clock-frequency = <25000000>;
>>> +             };
>>> +
>>> +             apb_pclk: apb_pclk {
>> No underscores in node names, but all these look incorrect - don't you
>> have clock controller?
> Noted, we will remove the "_" from the nodes. We do have clock 
> controller however that is being accessed by other CPU before Linux will 
> come-up.

What does it mean? Is the clock controller not available at all for
Linux or any other OS?

> 
> So, the purpose of this clock nodes is to calculate the frequencies for 
> other peripherals. (We will update the nodes with clock-<freq>)

You do not calculate any frequencies here... You created nodes for fixed
clocks but I question here whether these are fixed clocks.

Where are these clocks located exactly?


Best regards,
Krzysztof