From: "Arnd Bergmann" <arnd@arndb.de>
To: "kernel test robot" <lkp@intel.com>,
"Marek Behún" <kabel@kernel.org>, "Lee Jones" <lee@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, soc@kernel.org,
"Gregory Clement" <gregory.clement@bootlin.com>,
arm <arm@kernel.org>, "Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH leds v4 02/12] leds: turris-omnia: Use command execution functions from the MCU driver
Date: Fri, 01 Nov 2024 10:06:40 +0100 [thread overview]
Message-ID: <98d3ab51-e7db-46b0-8268-b111e115a281@app.fastmail.com> (raw)
In-Reply-To: <202410311612.0OkxKVgC-lkp@intel.com>
On Thu, Oct 31, 2024, at 10:01, kernel test robot wrote:
>
> kernel test robot noticed the following build warnings:
>>> drivers/leds/leds-turris-omnia.c:409:12: warning: stack frame size (2064) exceeds limit (2048) in 'omnia_leds_probe' [-Wframe-larger-than]
> 409 | static int omnia_leds_probe(struct i2c_client *client)
> | ^
The problem here is the i2c_client on the stack, you can't
do that:
static int omnia_mcu_get_features(const struct i2c_client *client)
{
+ struct i2c_client mcu_client = *client;
u16 reply;
I haven't looked at this in detail, but there is usually a
trivial alternative.
Arnd
next prev parent reply other threads:[~2024-11-01 9:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 13:56 [PATCH leds v4 00/12] Turris Omnia LED driver changes Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 01/12] turris-omnia-mcu-interface.h: Move command execution function to global header Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 02/12] leds: turris-omnia: Use command execution functions from the MCU driver Marek Behún
2024-10-31 9:01 ` kernel test robot
2024-11-01 9:06 ` Arnd Bergmann [this message]
2024-11-01 11:06 ` Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 03/12] turris-omnia-mcu-interface.h: Add LED commands related definitions to global header Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 04/12] leds: turris-omnia: Use global header for MCU command definitions Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 05/12] dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 06/12] leds: turris-omnia: Document driver private structures Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 07/12] leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change Marek Behún
2024-10-30 20:34 ` kernel test robot
2024-10-29 13:56 ` [PATCH leds v4 08/12] platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 09/12] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 10/12] leds: turris-omnia: Use dev_err_probe() where appropriate Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 11/12] leds: turris-omnia: Use uppercase first letter in all comments Marek Behún
2024-10-29 13:56 ` [PATCH leds v4 12/12] ARM: dts: turris-omnia: Add global LED brightness change interrupt Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d3ab51-e7db-46b0-8268-b111e115a281@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox