From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79779C433FE for ; Tue, 11 Oct 2022 09:06:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 4D524C43142; Tue, 11 Oct 2022 09:06:46 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id D9E89C433D6; Tue, 11 Oct 2022 09:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org D9E89C433D6 Authentication-Results: smtp.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665479205; x=1697015205; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EDe69pp5/h3Ee30GI4SHuwJ5qjyCZy1LPPLfzPY94CE=; b=gRYdK+8mHNWYZe7jLjznZshOtK8s3zXcDEEokXfOmPzcixlAsqGi7ki2 o3WcYiC1pZjwgBzBCjMSmkzGOncArjuaQtox/7QvMHQjRS+Oa46RrhlXf bzYuYuzmAamtlN24D/Fe+wAe9JMPHr3W5S7GIE2BA7+RMdgvl8ug2G8r9 T5J7Oeh7d/7CRTWkNR9Z77YFcBe8fJ3ZCL4qVEQYopd06KWLtpz92+QNP 12oh8Z6dxFLzl4HrI9lcK2+8UwgVMyF5PszRMGV56FYSifmdmJtQNXNIn SDXj44SL1w7jL+1HyKCWRDnkCUO2Pp6TZD4gqAAWrNBhIhVo8273ZyjGq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="302061952" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="302061952" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 02:06:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="659467328" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="659467328" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2022 02:06:21 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiBDL-005Eh1-1p; Tue, 11 Oct 2022 12:06:15 +0300 Date: Tue, 11 Oct 2022 12:06:15 +0300 From: Andy Shevchenko To: Emil Renner Berthing List-Id: Cc: Marc Zyngier , Bartosz Golaszewski , Kent Gibson , Mauro Carvalho Chehab , Billy Tsai , Thomas Gleixner , Linus Walleij , Mika Westerberg , AngeloGioacchino Del Regno , Chen-Yu Tsai , Claudiu Beznea , Samuel Holland , Horatiu Vultur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Lad Prabhakar , Phil Edworthy , Krzysztof Kozlowski , Fabien Dessenne , Prathamesh Shete , Basavaraj Natikar , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Thierry Reding , Jonathan Hunter , Patrice Chotard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Andrew Jeffery , Joel Stanley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Charles Keepax , Richard Fitzgerald , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Damien Le Moal , Tony Lindgren , Haojian Zhuang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Andy Gross , Konrad Dybcio , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Emil Renner Berthing , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v2 25/36] pinctrl: starfive: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-26-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Oct 11, 2022 at 10:31:33AM +0200, Emil Renner Berthing wrote: > On Mon, 10 Oct 2022 at 22:26, Andy Shevchenko > wrote: > > > > Do not imply that some of the generic headers may be always included. > > Instead, include explicitly what we are direct user of. > > > > While at it, sort headers alphabetically. > > The patch is fine, but I don't see any sorting other than just adding > the headers at the appropriate place. I will amend commit message here. > In any case > > Acked-by: Emil Renner Berthing Thank you! -- With Best Regards, Andy Shevchenko