From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EF9BE6FE36 for ; Fri, 22 Sep 2023 14:21:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id D9E3BC433CA; Fri, 22 Sep 2023 14:21:43 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id CC247C433C7; Fri, 22 Sep 2023 14:21:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org CC247C433C7 Authentication-Results: smtp.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="384674914" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="384674914" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:21:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="817793937" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="817793937" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:21:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qjh28-0000000HCq5-3dHg; Fri, 22 Sep 2023 17:21:28 +0300 Date: Fri, 22 Sep 2023 17:21:28 +0300 From: Andy Shevchenko To: Marek =?iso-8859-1?Q?Beh=FAn?= List-Id: Cc: Linus Walleij , Gregory CLEMENT , Arnd Bergmann , soc@kernel.org, arm@kernel.org, Bartosz Golaszewski , linux-gpio@vger.kernel.org, Dmitry Torokhov Subject: Re: [PATCH v2 3/7] platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs Message-ID: References: <20230919103815.16818-1-kabel@kernel.org> <20230919103815.16818-4-kabel@kernel.org> <20230921214541.0dae4d62@thinkpad> <20230921221409.4a01f541@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230921221409.4a01f541@thinkpad> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Sep 21, 2023 at 10:14:09PM +0200, Marek Behún wrote: > On Thu, 21 Sep 2023 21:45:57 +0200 > Marek Behún wrote: > > > I could use ffs(x) instead of ilog2(x) + 1. > > Pardon me, I meant fls(). Or maybe get_bitmask_order() from > linux/bitops.h. In any case it's bitops.h APIs that you will need and I think it's fine and Linus will approve that. -- With Best Regards, Andy Shevchenko