Re: [PATCH v6 08/11] devm-helpers: Add resource managed version of debugfs directory create function

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Apr 18, 2024 at 02:11:13PM +0200, Marek Behún wrote:
> A few drivers register a devm action to remove a debugfs directory,
> implementing a one-liner function that calls debufs_remove_recursive().
> Help drivers avoid this repeated implementations by adding managed
> version of debugfs directory create function.

...

> +static inline struct dentry *
> +devm_debugfs_create_dir(struct device *dev, const char *name,
> +			struct dentry *parent)
> +{
> +	struct dentry *dentry;
> +	int err;

> +	dentry = debugfs_create_dir(name, parent);
> +	if (IS_ERR(dentry))
> +		return dentry;

Why do we care?

> +	err = devm_add_action_or_reset(dev, devm_debugfs_dir_recursive_drop,
> +				       dentry);
> +	if (err < 0)
> +		return ERR_PTR(err);
> +
> +	return dentry;
> +}

static inline struct dentry *
devm_debugfs_create_dir(struct device *dev, const char *name, struct dentry *parent)
{
	struct dentry *dentry;
	int err;

	dentry = debugfs_create_dir(name, parent);

	err = devm_add_action_or_reset(dev, devm_debugfs_dir_recursive_drop, dentry);
	if (err)
		return ERR_PTR(err);

	return dentry;
}

?

-- 
With Best Regards,
Andy Shevchenko