From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B713488214 for ; Tue, 25 Aug 2026 15:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787670719; cv=none; b=jVZGzh5tFaUXoblmn4k57+Awkm0GS6RwT/dkCAMDbdIwvv2anSLIxJTuabiEVqUIrU8wLPGkhN8hKfCpesxh0iSQ1Icx+ncm5x1pWEisbbTJdD7/XNT9T0zLkSl+1eZsCWNtv7R+osJk75/Ny2bUeJBB5Uv/rAVAzDyT1tzUoKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787670719; c=relaxed/simple; bh=VSfhDbGuaO6bj6wZHF4WXo8dJZaWBr1sYjz3PhauiKg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=RLJyIQ0QtQl/gw9r4stKdhQm1WaNu59S3tO63L6MRbywuE+HmAicS4dLbMy1cM7PcAYSCnZFhjAZpldqbHClwwfOwY7S9ObL1btW3qnxDiG/SVuSVucXWLRT4/esIY/tgn6P6V6vy+aJ4PQg8CDNZ8jFqFiVB+t73FAvxsPzMVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cmNwOCPW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cmNwOCPW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787670715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2TAxOwHRDlM6cSmZF0xTyxxMoyKXBFa/St1ecjf+fY=; b=cmNwOCPW0pCLo1vgxbiI8024BSzxbFhi3JiPy5Bv8SJO4i3CWLe8pnJoGKFUOrad+B/b/+ ss0febDjN34CvxqR7kDJPsYhRohx65REzsx6IYHVayw4b9b70DhLTuDcUesPRiEXiPUqHm uTFVlFozsf2xG5Uyv+HbX3OiX5QSvDo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68--9ZsrpczOiyyMTu4dXycCQ-1; Tue, 25 Aug 2026 11:11:53 -0400 X-MC-Unique: -9ZsrpczOiyyMTu4dXycCQ-1 X-Mimecast-MFC-AGG-ID: -9ZsrpczOiyyMTu4dXycCQ_1787670713 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52769fc3f2eso70369571cf.0 for ; Tue, 25 Aug 2026 08:11:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787670712; x=1788275512; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=l2TAxOwHRDlM6cSmZF0xTyxxMoyKXBFa/St1ecjf+fY=; b=bbMmnxhgwshIUojL8TLDOqfDIFe3Cmvein8dHIMJ8uBFpl3xEm5zue2elrwTxBt0Lb mIsCmMDBR1s2N0/dTtAZeVV+vdZED2HG7HmvnpasNEsKDHeyaG5PrZflNF1cbEQJ+kSt HEMN6j+Zzzo382vsya2Sg5M3+NXH4TmKDXNb7/MyPs7aeg5XuXIVxJoF2MUnu7DKAejk lnPDHusZl4cImH+il1GklD8Q4JDYwjE+k3W3v0O9pkVE265nCBczNDd1Mdnkqbc2Hjzt M/YZ5VsgEKhG/Yb1CXG44GRBDsxAyYfmXLr/1q6MiBhn9LzvznZs5tUX3ESYVLqPtYpl zfvw== X-Forwarded-Encrypted: i=1; AHgh+Rr5MAUr8z17ZQ+yFylzvY+WyX+UwsLVQzj87DfeJ6823YA7fhkyLBvHC0Y0q4zYgfWOByI=@lists.linux.dev X-Gm-Message-State: AFuF++nBI6qLaDTGg30mSKJavXRQTWg2W6D0XZPJwGVhYKDyak+zYKLo OyQd0eGJrla4fSIKunMSQkEzcue5L/M9sZ5pkKAAcUP+UmOYTrz3MFPtyJHiq6L9BD6zmgSE6et 8c0gYotZB/PWX/hMGWp/buCCamysUL+Ud+IUblgqZ3FYwS8KHDm0BhQ== X-Gm-Gg: AR+sD12dDbZys9HKA3/e0bdqYUHfpFgzrVXs+hQd5+0bjGN6RQ1xzSV2+mA4Z/FW9AJ A74BX2C2qa0tcN2fP7V2LK4yFUj/u7vGQakSz3rR5IqiQSBOySLTY0+Mscw62WiC1pcGGO2HMcF Sa1oDt2uWDeCfuJaA+9d+oIDH5lroQstkJ6rbc/6G53doeC/oULAbEpF+GYPP30VgaZBcC4o3TQ J8bD70FxUAXtS6PADbXlzu8Z66+UE5Vc1v1yR1eSUKuQEIjUZp1V9k+9YlnFu6oXtPk+Tthmh41 iA4LPXIB0DWR3a9WnYIWBgcrx1zFXmkvadP7Urc16mc7bvrbwkdV1f1Y8to9t4jhfxm+SNgQ1PC +sQt1jvZ+SWfYkkUzNSVVOti5yF4FMabM9w0= X-Received: by 2002:ac8:7d13:0:b0:52d:3d46:bfd0 with SMTP id d75a77b69052e-52df5a4a41emr343136181cf.32.1787670712380; Tue, 25 Aug 2026 08:11:52 -0700 (PDT) X-Received: by 2002:ac8:7d13:0:b0:52d:3d46:bfd0 with SMTP id d75a77b69052e-52df5a4a41emr343134781cf.32.1787670711664; Tue, 25 Aug 2026 08:11:51 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52e09aad030sm71209161cf.15.2026.08.25.08.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 08:11:50 -0700 (PDT) Date: Tue, 25 Aug 2026 11:11:47 -0400 From: Brian Masney To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , Geert Uytterhoeven , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 00/45] clk: Make sure clk_init_data is fully initialized (part two) Message-ID: References: <3074509.irdbgypaU6@diego> Precedence: bulk X-Mailing-List: soc@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <3074509.irdbgypaU6@diego> User-Agent: Mutt/2.4.0 (2026-06-19) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oTjAoMhA-uzvTFieDzOrdweDFb5E1BUrlQXVWmje5lQ_1787670713 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Heiko, On Mon, Aug 24, 2026 at 11:11:32PM +0200, Heiko Stübner wrote: > Am Freitag, 21. August 2026, 10:53:10 Mitteleuropäische Sommerzeit schrieb Geert Uytterhoeven: > > Hi all, > > > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Hence this series aims to make sure all members are fully initialized, > > to avoid such bugs, and to prevent future breakage when converting > > drivers to a different method for specifying the parents. > > > > Part One[1] fixed all cases that I identified to be real bugs, in > > response to a crash I saw on BeagleBone Black. > > > > This series is the clock subpart of Part Two, which fixes remaining > > cases that are currently harmless. These are still fragile, and may > > cause future breakage when converting drivers to a different method for > > specifying the parents. > > > > Thanks for your comments! > > I guess more a handling question, how do you expect this series to be > applied? > > I.e. each clk-arch-maintainer, or in one big thing by the core clock > maintainers? Just wondering if I should pick the Rockchip patch > or just let the whole series get applied by the clock maintainers. Before you pick up anything, let's see if Stephen picks up this series the next few days before he sends his pull to Linus. Next development cycle, Jerome Brunet and I will be clk co-maintainers [1] and will start collecting patches then. If Stephen doesn't pick up this whole series this week, then pick up the patch(es) relevant for your tree and send Jerome and I pull as usual. That's just in case there's other patches that come in during the next development cycle to these files and to avoid merge conflicts. I don't have a strong opinion about this though, and could be convinced to take the whole series for simplicity. [1] https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=8bc7ceadce1f362a8b0e88075ef3d926b286c01c Brian