From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A063DFC86; Thu, 10 Sep 2026 09:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032443; cv=none; b=WWMTi5lSjLrDHov/MbN+CQNeLofSR31Zsa+Eqo83EjSkr5F2ZzUvGNvZK4Ymx05CjEp14u20NvQPwxitEFPIWGXTeGgk/2q1C10qpMn/lCcT4TKtt2+wUP8gmxlO1fxlgcFTMDTdG67QsfbLpCvjeaOfvaBUcbdjEmlVuGNM5NI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032443; c=relaxed/simple; bh=g9Cp6K2YW/0ojAZM+PERC3yWY2MaFiW9F9EZGEa+wq0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oTMWPMTH6Y8G+fFzW6dotLdIuH47SXKRmCv/GEEmv0GBui4LCFmCmwnHQU0Mgi6kYMZl179tygq5HmO3D1yUpmYkMS7j0hiKOGVehwrjR6Aw09FQGwZkYobLT2rvqRDfwDNe8fHQr3luL7vvlJVOTJzqPDH1MW+QEN084+bHsIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=c4hO+jTI; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="c4hO+jTI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789032438; x=1820568438; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g9Cp6K2YW/0ojAZM+PERC3yWY2MaFiW9F9EZGEa+wq0=; b=c4hO+jTIwQXz7JKZr5TY0zpwfKnqO4RbR5ybx8Oj97PTHC6OXc70FSWp 2wrhQm79IJB7K1K8vhWAmd7PPkaf9kwSYQIQZeDUXZibRTQFdQO9cW7hr WF9cKtuS0u0upadZ3Qr6iz6oD1ZGClNZivspgugmSFxzOY805bB6Ikm5V 8O4P3OOLO0QMoH4ZpeikHepY/sIYnJDYv7ocJrqK059Ikr5zDXrQUE2QX 3W52+0MH/w7RXTAujkC76d3BWnqnD5U5f9lsXU5keeYYGlZ4nGlBAxOEz TicWRzaTKIw4c0d9LSOH8VJ8B0fSzadH9p5kbFbKB6Ove34JLbxS317ZB w==; X-CSE-ConnectionGUID: r4XzqXZOQcGe12x3CuVMTA== X-CSE-MsgGUID: E7utcSa2Qiqy+BlD8UgpJw== X-IronPort-AV: E=McAfee;i="6800,10657,11900"; a="100068159" X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="100068159" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2026 02:27:09 -0700 X-CSE-ConnectionGUID: 9Lk46I8cT22DEwuQeaU5Rw== X-CSE-MsgGUID: YmZZHAgjTGqItji2nmnofw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="273537486" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.177]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2026 02:27:04 -0700 Date: Thu, 10 Sep 2026 12:27:02 +0300 From: Andy Shevchenko To: zl020895 Cc: longzhao@ambarella.com, Arnd Bergmann , Krzysztof Kozlowski , Alexandre Belloni , soc@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Catalin Marinas , Will Deacon , Lee Jones , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v6 11/13] serial: 8250_dw: add Ambarella CV75 quirks Message-ID: References: <20260904-cv75-v5-v6-0-e918514cb3b1@ambarella.com> <20260904-cv75-v5-v6-11-e918514cb3b1@ambarella.com> <122573f8.8232.1a08a9765fc.Coremail.zl020895@163.com> Precedence: bulk X-Mailing-List: soc@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <122573f8.8232.1a08a9765fc.Coremail.zl020895@163.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Sep 10, 2026 at 05:12:52PM +0800, zl020895 wrote: > > Wondering if we should undo this in the port's .shutdown() callback. > I saw the shutdown path already covers it: dw8250_shutdown() calls > serial8250_do_shutdown(), which does > up->ier = 0; > serial_port_out(port, UART_IER, 0); > so both the IER shadow and hardware IER are cleared, including ETOI. Depending on the answer to Ilpo the enabling may need an updated comment summarising the above. > At 2026-09-10 16:33:14, "Andy Shevchenko" wrote: > >On Fri, Sep 04, 2026 at 02:38:18PM +0800, Long Zhao via B4 Relay wrote: ... > >> + /* > >> + * Ambarella keeps variant IER bits (e.g. ETOI) set for correct RX > >> + * timeout behaviour. Force them into the 8250 IER shadow so later > >> + * generic IER updates do not clear them. > >> + */ > > > >Wondering if we should undo this in the port's .shutdown() callback. -- With Best Regards, Andy Shevchenko