soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Pali Rohár" <pali@kernel.org>, "Lee Jones" <lee@kernel.org>
Cc: soc@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH RESEND 4/8] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding
Date: Sat, 11 Mar 2023 12:47:13 +0100	[thread overview]
Message-ID: <bbd46675-5177-0463-1f99-bf5053988b43@kernel.org> (raw)
In-Reply-To: <20230309204245.c2ni462ajcqukrtg@pali>

On 09/03/2023 21:42, Pali Rohár wrote:
> On Friday 24 February 2023 09:38:37 Lee Jones wrote:
>> On Fri, 24 Feb 2023, Krzysztof Kozlowski wrote:
>>
>>> On 27/01/2023 12:16, Lee Jones wrote:
>>>> On Mon, 26 Dec 2022, Pali Rohár wrote:
>>>>
>>>>> Add device-tree bindings documentation for Turris 1.x RGB LEDs.
>>>>>
>>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>>> ---
>>>>>  .../bindings/leds/cznic,turris1x-leds.yaml    | 118 ++++++++++++++++++
>>>>>  1 file changed, 118 insertions(+)
>>>>>  create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml
>>>>
>>>> Needs a DT Ack (now Cc:ed)
>>>
>>> Within the same day of posting v2 of this - just after 4 hours, Pali
>>> received review and I pointed issue to address.
>>>
>>> The issue was not addressed, just ignored.
>>>
>>> Therefore this patch shall not be taken, until the issues are resolved
>>> or discussion is finished if there is disagreement about my comments..
>>
>> Understood.  Thanks for the clarification.
> 
> Sorry, but this discussion was ignored by the reviewer, not by me.
> I have replied to all points. In other cases I have sent other emails
> and result was same.
> 
> I'm not going to write and send emails or pull requests or other code to
> people who do not want to read them or think that it is me who is
> ignoring even it is false information.

Why did you trim the reply list from few folks and from me, even though
discussion is about review between you and me? You had to do it
deliberately, so I wonder why?

OK, you claim this is false information.

This is the last feedback from me:
https://lore.kernel.org/all/ebf5029e-83fd-e50d-b7cb-eae1b64f7145@linaro.org/

Where did you respond to this feedback? Point me to the message which
responds to my review comment about messed indentation?

Best regards,
Krzysztof


  reply	other threads:[~2023-03-11 11:47 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 12:36 [PATCH RESEND 0/8] Resend LED patches Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 1/8] dt-bindings: leds: register-bit-led: Add active-low property Pali Rohár
2023-01-27 11:16   ` Lee Jones
2023-02-23 14:22     ` Lee Jones
2023-02-23 16:48       ` Pali Rohár
2023-02-23 20:59         ` Linus Walleij
2023-02-24  8:42           ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 2/8] leds: syscon: Implement support for " Pali Rohár
2023-02-23 14:25   ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 3/8] powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board CPL Design Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 4/8] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Pali Rohár
2023-01-27 11:16   ` Lee Jones
2023-02-24  9:15     ` Krzysztof Kozlowski
2023-02-24  9:38       ` Lee Jones
2023-03-09 20:42         ` Pali Rohár
2023-03-11 11:47           ` Krzysztof Kozlowski [this message]
2023-02-24  9:13   ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 5/8] leds: Add support for Turris 1.x LEDs Pali Rohár
2023-01-27 11:20   ` Lee Jones
2023-02-02 23:46     ` Pali Rohár
2023-02-24  9:25     ` Krzysztof Kozlowski
2023-02-24  9:37       ` Lee Jones
2023-02-24  9:22   ` Krzysztof Kozlowski
2023-02-24  9:28   ` Lee Jones
2023-03-09 20:35     ` Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 6/8] leds: turris-omnia: support HW controlled mode via private trigger Pali Rohár
2023-02-24  9:32   ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 7/8] leds: turris-omnia: initialize multi-intensity to full Pali Rohár
2023-02-24  9:33   ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 8/8] leds: turris-omnia: change max brightness from 255 to 1 Pali Rohár
2023-02-24  9:34   ` Lee Jones
2023-03-09 20:07     ` Pali Rohár
2023-01-20 16:41 ` [PATCH RESEND 0/8] Resend LED patches Arnd Bergmann
2023-01-20 17:15   ` Lee Jones
2023-01-20 17:47     ` Arnd Bergmann
2023-01-20 20:02       ` Lee Jones
2023-01-26 20:07     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbd46675-5177-0463-1f99-bf5053988b43@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).