From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Rob Herring <robh@kernel.org>,
soc@kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Alexandre Mergnat" <amergnat@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values
Date: Tue, 12 Sep 2023 14:54:50 +0200 [thread overview]
Message-ID: <f8759d51-f808-8082-ceaf-6c6dcaebe2d9@collabora.com> (raw)
In-Reply-To: <20230804225813.12493-1-robh@kernel.org>
Il 05/08/23 00:58, Rob Herring ha scritto:
> The defined value for "status" is "disabled", not "disable".
>
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Please take this directly I guess. I think Mediatek maintainership
> needs some help. Maybe AngeloGioacchino should be co-maintainer as
> that's the only response I seem to be getting.
Sorry but I've seen this message just now as I've been on holiday in August.
Thing is, the MediaTek scene is starting to see more and more code, bringing
an obvious increase in the amount of reviews to be done and in the required
efforts to maintain the MTK bits - and we will possibly (hopefully) see even
more of that.
If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be
proud to become one.
Cheers,
Angelo
>
> I think for future .dts patches I will not bother splitting them up by
> sub-arch because it's a pain to chase down the maintainers to apply
> stuff in a timely manner. /rant
>
> arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index e4605d23fdc8..86cedb0bf1a9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -585,11 +585,11 @@ &pwrap {
> };
>
> &sata {
> - status = "disable";
> + status = "disabled";
> };
>
> &sata_phy {
> - status = "disable";
> + status = "disabled";
> };
>
> &spi0 {
next prev parent reply other threads:[~2023-09-12 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 22:58 [RESEND PATCH] arm64: dts: mediatek: Fix "status" values Rob Herring
2023-08-12 9:14 ` patchwork-bot+linux-soc
2023-09-12 12:54 ` AngeloGioacchino Del Regno [this message]
2023-09-12 13:10 ` Alexandre Mergnat
2023-09-13 8:49 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8759d51-f808-8082-ceaf-6c6dcaebe2d9@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox