From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: soc@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support
Date: Tue, 8 Nov 2022 12:13:26 +0100 [thread overview]
Message-ID: <f8f83839-2e76-e500-a16e-5fd2985a278d@linaro.org> (raw)
In-Reply-To: <20221107103410.3443-6-hayashi.kunihiko@socionext.com>
On 07/11/2022 11:34, Kunihiko Hayashi wrote:
> Initial version of devicetree sources for NX1 SoC and boards.
>
> NX1 SoC belongs to the UniPhier armv8 architecture platform, and is
> designed for IoT and AI/ML application fields.
>
> +
> + soc_glue: syscon@1f800000 {
> + compatible = "socionext,uniphier-nx1-soc-glue",
> + "simple-mfd", "syscon";
> + reg = <0x1f800000 0x2000>;
> +
> + pinctrl: pinctrl {
> + compatible = "socionext,uniphier-nx1-pinctrl";
So instead of documenting the hardware precisily, you have one big bag
for everything under simple-mfd. This is not how the SoC should be
described in DTS.
> + };
> + };
> +
> + soc-glue@1f900000 {
> + compatible = "simple-mfd";
No, it is not allowed on its own. You need a specific compatible and
bindings describing its children.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-08 11:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 10:34 [PATCH v2 0/5] Add UniPhier boards support Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 1/5] dt-bindings: arm: uniphier: Add system controller bindings Kunihiko Hayashi
2022-11-08 11:09 ` Krzysztof Kozlowski
2022-11-08 14:30 ` Kunihiko Hayashi
2022-11-08 15:08 ` Krzysztof Kozlowski
2022-11-11 8:49 ` Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 2/5] dt-bindings: arm: uniphier: Add Pro5 boards Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 3/5] ARM: dts: uniphier: Add Pro5 board support Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 4/5] dt-bindings: arm: uniphier: Add NX1 boards Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support Kunihiko Hayashi
2022-11-08 11:13 ` Krzysztof Kozlowski [this message]
2022-11-08 14:30 ` Kunihiko Hayashi
2022-11-08 15:11 ` Krzysztof Kozlowski
2022-11-11 8:48 ` Kunihiko Hayashi
2022-11-11 14:40 ` Krzysztof Kozlowski
2022-11-11 16:42 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f83839-2e76-e500-a16e-5fd2985a278d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox