From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A2A2BF009; Mon, 25 Aug 2025 08:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756111271; cv=none; b=Sce6MPBNUUdNDzyfjvCdGNC88wODCFfhZ6PDtSxfi83BC5VILvapz2jllBVa3wBZJySsg8Kav28wn2SLwh2P4dvacbOMIKS0/iLD1Tg6JOU5ay9A55FdHdXZh03re4dq/qsNMbNJLIKjfuFK3Lub9w9szxe6jkAFHZFiKZe/DZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756111271; c=relaxed/simple; bh=YvGhFydXbrmE9yimRweNKCZChGzfZ1CATQpB6bIekEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OIYT+iVRGZfxMUHy0dpsQXK65gfvAjGw7nN8V6Kn9vbRqIn0ERWxSQnTJedSNg6d61hDDiUMOhS5JXgIj43+6fTnq1HCcGxWuCdCaYW8SDKMOZcOr7K2aHhK+811K4UVpw3EEtH1jyJEZK0VXoxy9bD5AVH10ZCpQUuAEh7qyqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kOMZ2uUV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kOMZ2uUV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7064FC4CEF1; Mon, 25 Aug 2025 08:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756111270; bh=YvGhFydXbrmE9yimRweNKCZChGzfZ1CATQpB6bIekEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOMZ2uUVb/0wo3syOidoV1f0HRnUy2RJHSLMdGqk7yLVCovHqwhjwaAlh5RRjGhHZ vntVwdIrQaIPc6RHyWqxDvKuJf4yALVzvwSkz6MQRZOCjYqhY5PmaPIKYrOPpB1p8u ZQQcgaSOLbnXSBweKyIJlNLbQ4eko+2s1j1Kyd2DdcthL3uR+6Q+zm9V6VZoqVXEwk YjSDNkhA9rZ9AoJyJlfQ5AVgcfN/tGkd589lOdTPjxZRJZFSYBmnMyeGFXPtEjvyYF AaBOk5ZqAGeb9e0X69QoM8YFdfSFRB83tOPM4vDNmgfhRwb0C+7Wd6fILQWTsgyp8c FHQseDkSJrtGw== Date: Mon, 25 Aug 2025 16:41:07 +0800 From: Yixun Lan To: bmasney@redhat.com Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 050/114] clk: spacemit: ccu_mix: convert from round_rate() to determine_rate() Message-ID: <20250825084107-GYB1096417@kernel.org> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-50-b3bf97b038dc@redhat.com> Precedence: bulk X-Mailing-List: sophgo@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-50-b3bf97b038dc@redhat.com> Hi Brian, On 11:18 Mon 11 Aug , Brian Masney via B4 Relay wrote: > From: Brian Masney > > The round_rate() clk ops is deprecated, so migrate this driver from > round_rate() to determine_rate() using the Coccinelle semantic patch > on the cover letter of this series. > > Signed-off-by: Brian Masney Reviewed-by: Yixun Lan > --- > drivers/clk/spacemit/ccu_mix.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/spacemit/ccu_mix.c b/drivers/clk/spacemit/ccu_mix.c > index 9b852aa61f78aed5256bfe6fc3b01932d6db6256..7b7990875372314dce131295af7f40267d0a127a 100644 > --- a/drivers/clk/spacemit/ccu_mix.c > +++ b/drivers/clk/spacemit/ccu_mix.c > @@ -80,10 +80,12 @@ static int ccu_mix_trigger_fc(struct clk_hw *hw) > MIX_FC_TIMEOUT_US); > } > > -static long ccu_factor_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *prate) > +static int ccu_factor_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > - return ccu_factor_recalc_rate(hw, *prate); > + req->rate = ccu_factor_recalc_rate(hw, req->best_parent_rate); > + > + return 0; > } > > static int ccu_factor_set_rate(struct clk_hw *hw, unsigned long rate, > @@ -198,7 +200,7 @@ const struct clk_ops spacemit_ccu_gate_ops = { > }; > > const struct clk_ops spacemit_ccu_factor_ops = { > - .round_rate = ccu_factor_round_rate, > + .determine_rate = ccu_factor_determine_rate, > .recalc_rate = ccu_factor_recalc_rate, > .set_rate = ccu_factor_set_rate, > }; > @@ -220,7 +222,7 @@ const struct clk_ops spacemit_ccu_factor_gate_ops = { > .enable = ccu_gate_enable, > .is_enabled = ccu_gate_is_enabled, > > - .round_rate = ccu_factor_round_rate, > + .determine_rate = ccu_factor_determine_rate, > .recalc_rate = ccu_factor_recalc_rate, > .set_rate = ccu_factor_set_rate, > }; > > -- > 2.50.1 > > -- Yixun Lan (dlan)